r62217 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62216‎ | r62217 | r62218 >
Date:01:44, 10 February 2010
Author:demon
Status:ok
Tags:
Comment:
Reduce code duplication in requires
Modified paths:
  • /trunk/phase3/maintenance/doMaintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/doMaintenance.php
@@ -57,6 +57,10 @@
5858 require_once( "$IP/includes/ProfilerStub.php" );
5959 }
6060
 61+// Some other requires
 62+require_once( "$IP/includes/AutoLoader.php" );
 63+require_once( "$IP/includes/Defines.php" );
 64+
6165 // Load settings, using wikimedia-mode if needed
6266 // Fixme: replace this hack with general farm-friendly code
6367 if( file_exists( "$IP/wmf-config/wikimedia-mode" ) ) {
@@ -65,15 +69,11 @@
6670 global $cluster;
6771 $wgWikiFarm = true;
6872 $cluster = 'pmtpa';
69 - require_once( "$IP/includes/AutoLoader.php" );
7073 require_once( "$IP/includes/SiteConfiguration.php" );
7174 require( "$IP/wmf-config/wgConf.php" );
7275 $maintenance->loadWikimediaSettings();
73 - require( $IP.'/includes/Defines.php' );
7476 require( $IP.'/wmf-config/CommonSettings.php' );
7577 } else {
76 - require_once( "$IP/includes/AutoLoader.php" );
77 - require_once( "$IP/includes/Defines.php" );
7878 require_once( $maintenance->loadSettings() );
7979 }
8080 $maintenance->finalSetup();

Status & tagging log