r62167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62166‎ | r62167 | r62168 >
Date:06:12, 9 February 2010
Author:tstarling
Status:ok
Tags:
Comment:
Revert r58635 and related, unnecessary and incorrect use of the hook mechanism
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -552,11 +552,6 @@
553553 'BookInformation': Before information output on Special:Booksources
554554 $isbn: ISBN to show information for
555555 $output: OutputPage object in use
556 -
557 -'CacheHeadersAfterSet': after cache headers have been set in
558 -OutputPage::sendCacheControl, so they can be overridden without
559 -disabling output method
560 -$out: OutputPage instance
561556
562557 'CategoryPageView': before viewing a categorypage in CategoryPage::view
563558 $catpage: CategoryPage instance
Index: trunk/phase3/includes/OutputPage.php
@@ -1401,7 +1401,6 @@
14021402 $response->header( 'Cache-Control: no-cache, no-store, max-age=0, must-revalidate' );
14031403 $response->header( 'Pragma: no-cache' );
14041404 }
1405 - wfRunHooks('CacheHeadersAfterSet', array( $this ) );
14061405 }
14071406
14081407 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58635Add hook CacheHeadersAfterSet to permit override of cache headers laterariel10:53, 6 November 2009

Status & tagging log