r62161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62160‎ | r62161 | r62162 >
Date:03:04, 9 February 2010
Author:werdna
Status:deferred
Tags:
Comment:
LiquidThreads: Turn "More" into an a, instead of a span, allowing it to be accessed from the keyboard
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -956,7 +956,8 @@
957957 $menuHTML = Xml::tags( 'ul', array( 'class' => 'lqt-thread-toolbar-command-list' ),
958958 $this->listItemsForCommands( $commands ) );
959959
960 - $triggerText = Xml::tags( 'span', array( 'class' => 'lqt-thread-actions-icon' ),
 960+ $triggerText = Xml::tags( 'a', array( 'class' => 'lqt-thread-actions-icon',
 961+ 'href' => '#' ),
961962 wfMsgHTML( 'lqt-menu-trigger' ) );
962963 $dropDownTrigger = Xml::tags( 'div',
963964 array( 'class' => 'lqt-thread-actions-trigger ' .
Index: trunk/extensions/LiquidThreads/lqt.js
@@ -356,6 +356,7 @@
357357 trigger.click(
358358 function(e) {
359359 e.stopImmediatePropagation();
 360+ e.preventDefault();
360361
361362 // Hide the other menus
362363 $j('.lqt-thread-toolbar-command-list').not(menu).hide('fast');

Status & tagging log