r62149 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62148‎ | r62149 | r62150 >
Date:01:02, 9 February 2010
Author:dale
Status:deferred
Tags:
Comment:
* bumped mwRemoteVersion for update
* removed style sheet check that does not work cross-domain ( bits.wikimedia.org )
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/mwEmbed.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/mwEmbed.js
@@ -2376,10 +2376,10 @@
23772377 mw.setConfig( 'jquery_skin_path', mw.getMwEmbedPath() + 'jquery/jquery.ui/themes/' + mw.getConfig( 'jQueryUISkin' ) + '/' );
23782378
23792379 // Only load jquery ui theme sheet if ui-widget does not exist.
2380 - // NOTE: this rule test sucks cuz it does not work cross domain
2381 - if( ! mw.styleRuleExists( 'ui-widget' ) ){
 2380+ // NOTE: disabled as style sheets are cross domain and it behaves differently across browsers
 2381+ //if( ! mw.styleRuleExists( 'ui-widget' ) ){
23822382 mw.getStyleSheet( mw.getConfig( 'jquery_skin_path' ) + 'jquery-ui-1.7.1.custom.css' );
2383 - }
 2383+ //}
23842384
23852385 mw.setConfig( 'images_path', mw.getMwEmbedPath() + 'skins/common/images/' );
23862386
Index: branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r92';
 8+var mwRemoteVersion = 'r93';
99 var mwUseScriptLoader = true;
1010
1111 // Log the mwRemote version ( will determine what version of js we get )

Status & tagging log