r62072 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r62071‎ | r62072 | r62073 >
Date:16:20, 6 February 2010
Author:avar
Status:ok
Tags:
Comment:
Make 'make tap' the default target and add a 'make phpunit' target to
run things with phpunit.

phpunit as-is consumed up to 800MB of memory on PHP 5.2.12. Running it
also results in test failures for LanguageConverterTest.php which is
tripping over some setup code a previous test made.

The TAP target also runs in ~15 seconds on my machine, whereas I have
to kill phpunit after 8 minutes of running tests & eating my memory.
Modified paths:
  • /trunk/phase3/maintenance/tests/Makefile (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/Makefile
——@@ -1,17 +1,23 @@
 2+# See
 3+# http://lists.wikimedia.org/pipermail/wikitech-l/2010-February/046657.html
 4+# for why prove(1) is the default target and not phpunit(1)
 5+
26 .PHONY: help test
3 -all test:
4 - phpunit
 7+all test: tap
58
69 tap:
710 prove -e 'phpunit --tap' *Test*.php
811
 12+phpunit:
 13+ phpunit
 14+
915 install:
1016 pear channel-discover pear.phpunit.de
1117 pear install phpunit/PHPUnit
1218
1319 help:
1420 # Options:
15 - # test (default) Run the unit tests
16 - # tap Run the tests individually through Test::Harness's prove(1)
 21+ # test (default) Run the tests individually through Test::Harness's prove(1)
 22+ # phpunit Run all the tests with phpunit
1723 # install Install PHPUnit from phpunit.de
1824 # help You're looking at it!

Status & tagging log