r62068 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62067‎ | r62068 | r62069 >
Date:14:56, 6 February 2010
Author:ialex
Status:ok
Tags:
Comment:
Put $this->out and related in execute() rather than the constructor so that this part is only executed when needed
Modified paths:
  • /trunk/extensions/Translate/SpecialFirstSteps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialFirstSteps.php
@@ -20,13 +20,14 @@
2121
2222 public function __construct() {
2323 parent::__construct( 'FirstSteps' );
 24+ }
 25+
 26+ public function execute( $params ) {
2427 global $wgOut, $wgUser;
2528 $this->out = $wgOut;
2629 $this->user = $wgUser;
2730 $this->skin = $wgUser->getSkin();
28 - }
2931
30 - public function execute( $params ) {
3132 $this->out->addWikiMsg( 'translate-fs-intro' );
3233 $step = false;
3334

Status & tagging log