r62059 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62058‎ | r62059 | r62060 >
Date:02:12, 6 February 2010
Author:avar
Status:ok
Tags:
Comment:
Removing stub __construct() function. This was never called on PHP 5.2
and I'd wager on no PHP version since __construct was itroduced.

The code should probably just use __construct() for its main
constructor but maybe it also works on PHP 4.
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -26,7 +26,6 @@
2727 * Sets $wgShowEXIF to true when file is a tiff file.
2828 * This does not influence other ImageHandlers, which are possibly dependent on read-exif-data.
2929 */
30 - function __construct() { $this->PagedTiffHandler(); }
3130 function PagedTiffHandler() {
3231 global $wgShowEXIF;
3332 $wgShowEXIF = true;

Status & tagging log