r62032 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62031‎ | r62032 | r62033 >
Date:16:44, 5 February 2010
Author:j
Status:deferred
Tags:
Comment:
update Firefogg dependency to 1.1.0, cancel works in windows now, fixes: 21875
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/AddMedia/mw.Firefogg.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/modules/AddMedia/mw.Firefogg.js
@@ -116,7 +116,7 @@
117117 return this.init( options );
118118 };
119119 mw.Firefogg.prototype = { // extends mw.BaseUploadInterface
120 - min_firefogg_version: '0.9.9.5',
 120+ min_firefogg_version: '1.1.0',
121121 default_encoder_settings: { // NOTE: allow the server to set these
122122 'maxSize' : '400',
123123 'videoBitrate' : '544',
@@ -1150,14 +1150,9 @@
11511151 }
11521152 mw.log( 'firefogg:cancel' )
11531153 if ( confirm( gM( 'mwe-cancel-confim' ) ) ) {
1154 - // FIXME: sillyness ( upstream firefogg cancel fix needed )
1155 - if ( navigator.oscpu && navigator.oscpu.search( 'Win' ) >= 0 ) {
1156 - alert( 'sorry we do not yet support cancel on windows' );
1157 - } else {
1158 - this.action_done = true;
1159 - this.fogg.cancel();
1160 - $j( dialogElement ).empty().dialog( 'close' );
1161 - }
 1154+ this.action_done = true;
 1155+ this.fogg.cancel();
 1156+ $j( dialogElement ).empty().dialog( 'close' );
11621157 }
11631158 // Don't follow the # link:
11641159 return false;

Status & tagging log