r62003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62002‎ | r62003 | r62004 >
Date:02:12, 5 February 2010
Author:simetrical
Status:ok
Tags:
Comment:
Use HTML instead of EOT to delimit heredocs

This makes vim highlight the fragment as HTML.
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -1736,7 +1736,7 @@
17371737 function writeSuccessMessage() {
17381738 $script = defined('MW_INSTALL_PHP5_EXT') ? 'index.php5' : 'index.php';
17391739 if ( wfIniGetBool( 'safe_mode' ) && !ini_get( 'open_basedir' ) ) {
1740 - echo <<<EOT
 1740+ echo <<<HTML
17411741 <div class="success-box">
17421742 <p>Installation successful!</p>
17431743 <p>To complete the installation, please do the following:
@@ -1751,9 +1751,9 @@
17521752 which means that anyone on the same server can read your database password! Downloading
17531753 it and uploading it again will hopefully change the ownership to a user ID specific to you.</p>
17541754 </div>
1755 -EOT;
 1755+HTML;
17561756 } else {
1757 - echo <<<EOT
 1757+ echo <<<HTML
17581758 <div class="success-box">
17591759 <p>
17601760 <span class="success-message">Installation successful!</span>
@@ -1762,7 +1762,7 @@
17631763 <p>You should change file permissions for <tt>LocalSettings.php</tt> as required to
17641764 prevent other users on the server reading passwords and altering configuration data.</p>
17651765 </div>
1766 -EOT;
 1766+HTML;
17671767 }
17681768 }
17691769

Status & tagging log