r61935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61934‎ | r61935 | r61936 >
Date:15:57, 3 February 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Follow-up r61055: prevent "\n" appearing as text.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -1215,7 +1215,7 @@
12161216 $id = User::idFromName( $rootPart );
12171217 $ip = User::isIP( $rootPart );
12181218 if ( $id == 0 && !$ip ) { # User does not exist
1219 - $wgOut->wrapWikiMsg( '<div class="mw-userpage-userdoesnotexist error">\n$1</div>',
 1219+ $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n\$1</div>",
12201220 array( 'userpage-userdoesnotexist-view', $rootPart ) );
12211221 }
12221222 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61055(bug 19226) First line renders differently on many UI messages...platonides17:14, 14 January 2010

Comments

#Comment by Platonides (talk | contribs)   18:00, 3 February 2010

My bad. Thanks siebrand.

#Comment by Siebrand (talk | contribs)   18:09, 3 February 2010

I recall one of my commit summaries being "Gotta love quotes"...

Status & tagging log