r61900 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61899‎ | r61900 | r61901 >
Date:00:49, 3 February 2010
Author:dale
Status:deferred
Tags:
Comment:
* IE regression fix.
* kaltura search code comment
* bumed mediaWiki remote version
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/jsScriptLoader.php (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/AddMedia/searchLibs/kalturaSearch.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/modules/ApiProxy/mw.proxy.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/mwEmbed.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/tests/Player_Themable.html (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/tests/Player_Timed_Text.html (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/tests/Player_Themable.html
@@ -9,7 +9,6 @@
1010 <link rel="stylesheet" href="../skins/mvpcf/EmbedPlayer.css" type="text/css" media="screen" />
1111 <link rel="stylesheet" href="../skins/kskin/EmbedPlayer.css" type="text/css" media="screen" />
1212 -->
13 -
1413 <script type="text/javascript" src="../mwEmbed.js?debug=true"></script>
1514
1615
@@ -27,7 +26,7 @@
2827 apiTitleKey="Charles_Lindbergh_flight_to_Brussels.ogg"
2928 apiProvider="commons"
3029 durationHint="60">
31 -</video>
 30+</video>
3231
3332 <video
3433 style="width:208px;height:160px;float:left"
Index: branches/js2-work/phase3/js/mwEmbed/tests/Player_Timed_Text.html
@@ -19,6 +19,7 @@
2020 src="http://upload.wikimedia.org/wikipedia/commons/d/d6/Yochai_Benkler_-_On_Autonomy%2C_Control_and_Cultureal_Experience.ogg"
2121 poster="http://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/Yochai_Benkler_-_On_Autonomy%2C_Control_and_Cultureal_Experience.ogg/mid-Yochai_Benkler_-_On_Autonomy%2C_Control_and_Cultureal_Experience.ogg.jpg"
2222 apiTitleKey="Yochai_Benkler_-_On_Autonomy,_Control_and_Cultureal_Experience.ogg"
 23+ apiProvider="commons"
2324 class="kskin"></video>
2425 <td valign="top">
2526 Commons Video API based timedText discovery<br>
Index: branches/js2-work/phase3/js/mwEmbed/modules/AddMedia/searchLibs/kalturaSearch.js
@@ -81,7 +81,7 @@
8282 * Create an HTML representation of the available search filters and append
8383 * them to the given element.
8484 *
85 - * @param {jQuery element} The base element to which HTML items should be
 85+ * @return {jQuery element} The base element to which HTML items should be
8686 * appended.
8787 */
8888
@@ -123,6 +123,8 @@
124124 * @id {string} unique id for this filter box an residing elements
125125 * @title {string} title of the filter box
126126 * @options {array} array of strings describing the options in the filter box
 127+ *
 128+ * @return {jQuery element} The filter box
127129 *
128130 */
129131
@@ -282,6 +284,7 @@
283285 searchLib.getImageObj( resource, size, callback );
284286 });
285287 },
 288+
286289 /*
287290 * Get extra resource info via a library specific callback
288291 * NOTE: this info should be included in the original kaltura search results
@@ -292,6 +295,7 @@
293296 searchLib.addResourceInfoCallback( resource, callback );
294297 });
295298 },
 299+
296300 /**
297301 * Get and load provider via id
298302 * @param {String} provider_id The id of the content provider
Index: branches/js2-work/phase3/js/mwEmbed/modules/ApiProxy/mw.proxy.js
@@ -132,14 +132,14 @@
133133
134134 // add an onLoad hook:
135135 $j( '#frame_proxy' ).get( 0 ).onload = function() {
136 - // add a 5 second timeout for setting up the nested child callback (after page load)
 136+ // add a 8 second timeout for setting up the nested child callback (after page load)
137137 setTimeout( function() {
138138 if ( !frameProxyOk ) {
139139 // we timmed out no api proxy (should make sure the user is "logged in")
140140 mw.log( "Error:: api proxy timeout are we logged in? mwEmbed is on?" );
141141 $.proxy.proxyNotReadyDialog();
142142 }
143 - }, 5000 );
 143+ }, 8000 );
144144 }
145145 }
146146 var lastApiReq = { };
Index: branches/js2-work/phase3/js/mwEmbed/mwEmbed.js
@@ -1428,7 +1428,7 @@
14291429 // NOTE:: we need to setup a special page rather than the rewrite hack I use bellow:
14301430 // The rewrite hack is very slow cuz it loads the whole mediaWiki interface & skin
14311431 'server_frame' : server_frame,
1432 - 'client_frame_path' : mw.getMwEmbedPath() + 'modules/ApiProxy/NestedCallbackIframe.html',
 1432+ 'client_frame_path' : mw.getMwEmbedPath() + 'modules/ApiProxy/NestedCallbackIframe.html'
14331433 },
14341434 function(){
14351435 mw.proxy.doRequest( data, callback )
Index: branches/js2-work/phase3/js/mwEmbed/jsScriptLoader.php
@@ -180,7 +180,7 @@
181181 if( !is_file( $wgJavaPath ) || ! is_file( $wgClosureCompilerPath ) ){
182182 return false;
183183 }
184 - // Update the requestKey with a random value if no provided
 184+ // Update the requestKey with a random value if not provided
185185 // requestKey is used for the temporary file
186186 // ( There are problems with using standard output and Closure compile )
187187 if( $requestKey == '')
Index: branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js
@@ -4,10 +4,10 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r86';
 8+var mwRemoteVersion = 'r87';
99 var mwUseScriptLoader = true;
1010
11 -//Log the mwRemote version ( will determin what version of js we get )
 11+//Log the mwRemote version ( will determine what version of js we get )
1212 if( window.console ){
1313 window.console.log( 'mwEmbed:remote:' + mwRemoteVersion );
1414 }

Status & tagging log