r61890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61889‎ | r61890 | r61891 >
Date:22:05, 2 February 2010
Author:yaron
Status:deferred
Tags:
Comment:
formHTML() now takes another parameter, 'form ID'
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_AddData.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_EditData.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_RunQuery.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_AddData.php
@@ -129,7 +129,7 @@
130130 $page_contents = null;
131131 }
132132 list ($form_text, $javascript_text, $data_text, $form_page_title, $generated_page_name) =
133 - $sfgFormPrinter->formHTML($form_definition, $form_submitted, $page_is_source, $page_contents, $page_title, $page_name_formula);
 133+ $sfgFormPrinter->formHTML($form_definition, $form_article->getID(), $form_submitted, $page_is_source, $page_contents, $page_title, $page_name_formula);
134134 if ($form_submitted) {
135135 if ($page_name_formula != '') {
136136 $target_name = $generated_page_name;
Index: trunk/extensions/SemanticForms/specials/SF_RunQuery.php
@@ -70,7 +70,7 @@
7171 $is_text_source = true;
7272 }
7373 list ($form_text, $javascript_text, $data_text, $form_page_title) =
74 - $sfgFormPrinter->formHTML($form_definition, $form_submitted, $is_text_source, $edit_content, null, null, true, $embedded);
 74+ $sfgFormPrinter->formHTML($form_definition, $form_article->getID(), $form_submitted, $is_text_source, $edit_content, null, null, true, $embedded);
7575 $text = "";
7676 // override the default title for this page if
7777 // a title was specified in the form
Index: trunk/extensions/SemanticForms/specials/SF_EditData.php
@@ -96,7 +96,7 @@
9797 $is_text_source = true;
9898 }
9999 list ($form_text, $javascript_text, $data_text, $form_page_title) =
100 - $sfgFormPrinter->formHTML($form_definition, $form_submitted, $is_text_source, $edit_content, $page_title);
 100+ $sfgFormPrinter->formHTML($form_definition, $form_article->getID(), $form_submitted, $is_text_source, $edit_content, $page_title);
101101 if ($form_submitted) {
102102 $wgOut->setArticleBodyOnly( true );
103103 $text = SFUtils::printRedirectForm($target_title, $data_text, $wgRequest->getVal('wpSummary'), $save_page, $preview_page, $diff_page, $wgRequest->getCheck('wpMinoredit'), $wgRequest->getCheck('wpWatchthis'), $wgRequest->getVal('wpStarttime'), $wgRequest->getVal('wpEdittime'));

Status & tagging log