r61871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61870‎ | r61871 | r61872 >
Date:20:33, 2 February 2010
Author:dantman
Status:deferred
Tags:
Comment:
Fix a bug in MessageCommons causing default messages to override language customized ones. (I never actually tested in this case until now)
Modified paths:
  • /trunk/extensions/MessageCommons/MessageCommons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MessageCommons/MessageCommons.php
@@ -44,7 +44,7 @@
4545 } elseif( !isset($wgSharedDB) ) {
4646 $egMessageCommonsDatabase = $wgSharedDB;
4747 if( isset($wgSharedPrefix) ) {
48 - $egMessageCommonsPrefix = $wgSharedPrefix;
 48+ $egMessageCommonsPrefix = $wgSharedPrefix;
4949 }
5050 }
5151 }
@@ -64,7 +64,7 @@
6565 $msgNames[] = sprintf( '%s/%s', $msgName, $wgLang->getCode() );
6666 $msgNames[] = sprintf( '%s/%s', $msgName, $wgContLang->getCode() );
6767 }
68 - $msgNames = array_unique($msgNames);
 68+ $msgNames = array_reverse(array_unique($msgNames));
6969
7070 foreach( $msgNames as $msgName ) {
7171 $text = efMessageCommonsGetMsg( $msgName );

Status & tagging log