r61815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61814‎ | r61815 | r61816 >
Date:20:39, 1 February 2010
Author:philip
Status:ok
Tags:
Comment:
Fix a bug found in Makefile.py.
Modified paths:
  • /trunk/phase3/includes/ZhConversion.php (modified) (history)
  • /trunk/phase3/includes/zhtable/Makefile.py (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/zhtable/Makefile.py
@@ -255,14 +255,14 @@
256256 return ret
257257
258258 def GetPHPArray( table ):
259 - lines = ['\'%s\' => \'%s\',' % (f, t) for (f, t) in table]
 259+ lines = ['\'%s\' => \'%s\',' % (f, t) for (f, t) in table if f and t]
260260 #lines = ['"%s"=>"%s",' % (f, t) for (f, t) in table]
261261 return '\n'.join(lines)
262262
263263 def RemoveSameChar( src_table ):
264264 dst_table = {}
265265 for f, t in src_table.items():
266 - if not f == t:
 266+ if f != t:
267267 dst_table[f] = t
268268 return dst_table
269269
Index: trunk/phase3/includes/ZhConversion.php
@@ -2745,7 +2745,6 @@
27462746 '𫛢' => '鸋',
27472747 '𫛶' => '鶒',
27482748 '𫛸' => '鶗',
2749 -'' => '',
27502749 '0多只' => '0多隻',
27512750 '0天后' => '0天後',
27522751 '0只' => '0隻',
@@ -18021,4 +18020,4 @@
1802218021 '笨豬跳' => '绑紧跳',
1802318022 '蹦极跳' => '绑紧跳',
1802418023 '笑星' => '谐星',
18025 -);
\ No newline at end of file
 18024+);

Status & tagging log