r61793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61792‎ | r61793 | r61794 >
Date:15:36, 1 February 2010
Author:catrope
Status:ok
Tags:
Comment:
Whitespace fixes for r61761, r61779
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromChunks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadFromChunks.php
@@ -89,7 +89,7 @@
9090 */
9191 protected function initFromSessionKey( $sessionKey, $sessionData ) {
9292 // testing against null because we don't want to cause obscure
93 - // bugs when $sessionKey is full of "0"
 93+ // bugs when $sessionKey is full of "0"
9494 if ( !$sessionKey === null ) {
9595 $this->status = Status::newFromFatal( 'import-token-mismatch' );
9696 return;
Index: trunk/phase3/includes/api/ApiQueryDeletedrevs.php
@@ -197,7 +197,7 @@
198198
199199 $title = Title::makeTitle( $row->ar_namespace, $row->ar_title );
200200
201 - if ( $fld_parsedcomment) {
 201+ if ( $fld_parsedcomment ) {
202202 global $wgUser;
203203 $rev['parsedcomment'] = $wgUser->getSkin()->formatComment( $row->ar_comment, $title );
204204 }
Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -217,13 +217,13 @@
218218 $vals['pageid'] = intval( $row->page_id );
219219 }
220220
221 - $title = Title :: makeTitle( $row->log_namespace, $row->log_title );
 221+ $title = Title::makeTitle( $row->log_namespace, $row->log_title );
222222
223223 if ( $this->fld_title ) {
224224 if ( LogEventsList::isDeleted( $row, LogPage::DELETED_ACTION ) ) {
225225 $vals['actionhidden'] = '';
226226 } else {
227 - ApiQueryBase :: addTitleInfo( $vals, $title );
 227+ ApiQueryBase::addTitleInfo( $vals, $title );
228228 }
229229 }
230230
@@ -255,7 +255,7 @@
256256 $vals['timestamp'] = wfTimestamp( TS_ISO_8601, $row->log_timestamp );
257257 }
258258
259 - if ( ($this->fld_comment || $this->fld_parsedcomment) && isset( $row->log_comment ) ) {
 259+ if ( ( $this->fld_comment || $this->fld_parsedcomment ) && isset( $row->log_comment ) ) {
260260 if ( LogEventsList::isDeleted( $row, LogPage::DELETED_COMMENT ) ) {
261261 $vals['commenthidden'] = '';
262262 } else {
Index: trunk/phase3/includes/api/ApiQueryWatchlist.php
@@ -233,10 +233,10 @@
234234 $vals['revid'] = intval( $row->rc_this_oldid );
235235 }
236236
237 - $title = Title :: makeTitle( $row->rc_namespace, $row->rc_title );
 237+ $title = Title::makeTitle( $row->rc_namespace, $row->rc_title );
238238
239239 if ( $this->fld_title )
240 - ApiQueryBase :: addTitleInfo( $vals, $title );
 240+ ApiQueryBase::addTitleInfo( $vals, $title );
241241
242242 if ( $this->fld_user ) {
243243 $vals['user'] = $row->rc_user_text;
Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
@@ -279,10 +279,10 @@
280280 // $vals['textid'] = intval($row->rev_text_id); // todo: Should this field be exposed?
281281 }
282282
283 - $title = Title :: makeTitle( $row->page_namespace, $row->page_title );
 283+ $title = Title::makeTitle( $row->page_namespace, $row->page_title );
284284
285285 if ( $this->fld_title )
286 - ApiQueryBase :: addTitleInfo( $vals, $title );
 286+ ApiQueryBase::addTitleInfo( $vals, $title );
287287
288288 if ( $this->fld_timestamp )
289289 $vals['timestamp'] = wfTimestamp( TS_ISO_8601, $row->rev_timestamp );
@@ -296,7 +296,7 @@
297297 $vals['top'] = '';
298298 }
299299
300 - if ( ($this->fld_comment || $this->fld_parsedcomment) && isset( $row->rev_comment ) ) {
 300+ if ( ( $this->fld_comment || $this->fld_parsedcomment ) && isset( $row->rev_comment ) ) {
301301 if ( $row->rev_deleted & Revision::DELETED_COMMENT )
302302 $vals['commenthidden'] = '';
303303 else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61761Finish (bug 18427) Comment (edit summary) parser option for API...reedy23:06, 31 January 2010
r61779follow up r61355, initial, incomplete dealing with TimStarlings CRmah07:05, 1 February 2010

Status & tagging log