r61712 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61711‎ | r61712 | r61713 >
Date:12:09, 30 January 2010
Author:catrope
Status:ok
Tags:
Comment:
API: Fix E_NOTICE. !is_null() and isset() are not equivalent when indexing arrays
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
@@ -255,7 +255,7 @@
256256 $this->addFields( 'ts_tags' );
257257 }
258258
259 - if ( !is_null( $this->params['tag'] ) ) {
 259+ if ( isset( $this->params['tag'] ) ) {
260260 $this->addTables( 'change_tag' );
261261 $this->addJoinConds( array( 'change_tag' => array( 'INNER JOIN', array( 'rev_id=ct_rev_id' ) ) ) );
262262 $this->addWhereFld( 'ct_tag', $this->params['tag'] );

Status & tagging log