r61706 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61705‎ | r61706 | r61707 >
Date:07:24, 30 January 2010
Author:aaron
Status:ok
Tags:
Comment:
* Various cleanups/doc tweaks
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -413,9 +413,8 @@
414414 # Override redirect behavior...
415415 $wgHooks['InitializeArticleMaybeRedirect'][] = 'FlaggedRevsHooks::overrideRedirect';
416416 # Set page view tabs
417 -$wgHooks['SkinTemplateTabs'][] = 'FlaggedRevsHooks::setActionTabs';
418 -# Set navigation
419 -$wgHooks['SkinTemplateNavigation'][] = 'FlaggedRevsHooks::setNavigation';
 417+$wgHooks['SkinTemplateTabs'][] = 'FlaggedRevsHooks::setActionTabs'; // Most skins
 418+$wgHooks['SkinTemplateNavigation'][] = 'FlaggedRevsHooks::setNavigation'; // Vector
420419 # Add notice tags to edit view
421420 $wgHooks['EditPage::showEditForm:initial'][] = 'FlaggedRevsHooks::addToEditView';
422421 # Add draft link to section edit error
Index: trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php
@@ -27,10 +27,12 @@
2828 global $wgUser;
2929 # Add history link showing edits right before the config change
3030 $links = ' (';
31 - $links .= $wgUser->getSkin()->link( $title,
 31+ $links .= $wgUser->getSkin()->link(
 32+ $title,
3233 wfMsgHtml( 'hist' ),
3334 array(),
34 - array( 'action' => 'history', 'offset' => $timestamp ) );
 35+ array( 'action' => 'history', 'offset' => $timestamp )
 36+ );
3537 $links .= ')';
3638 return $links;
3739 }
@@ -52,9 +54,11 @@
5355 ? 'review-logentry-diff2' // unreviewed
5456 : 'review-logentry-diff'; // reviewed
5557 $links .= '(';
56 - $links .= $wgUser->getSkin()->makeKnownLinkObj( $title,
 58+ $links .= $wgUser->getSkin()->makeKnownLinkObj(
 59+ $title,
5760 wfMsgHtml( $msg ),
58 - "oldid={$oldStable}&diff={$revId}" );
 61+ "oldid={$oldStable}&diff={$revId}"
 62+ );
5963 $links .= ')';
6064 }
6165 # Show a diff link to this revision
@@ -63,9 +67,11 @@
6468 : $params[2];
6569 $time = $wgLang->timeanddate( $ts );
6670 $links .= ' (';
67 - $links .= $wgUser->getSkin()->makeKnownLinkObj( $title,
 71+ $links .= $wgUser->getSkin()->makeKnownLinkObj(
 72+ $title,
6873 wfMsgHtml( 'review-logentry-id', $revId, $time ),
69 - "oldid={$revId}&diff=prev&diffonly=0" );
 74+ "oldid={$revId}&diff=prev&diffonly=0"
 75+ );
7076 $links .= ')';
7177 }
7278 return $links;

Status & tagging log