r61670 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61669‎ | r61670 | r61671 >
Date:17:27, 29 January 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 22315) SpecialRecentChangesQuery hook now pass $query_options and checks the return value
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1479,6 +1479,7 @@
14801480 &$tables: array of tables to be queried
14811481 &$join_conds: join conditions for the tables
14821482 $opts: FormOptions for this request
 1483+&$query_options: array of options for the database request
14831484
14841485 'SpecialSearchNogomatch': called when user clicked the "Go" button but the
14851486 target doesn't exist
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -295,7 +295,8 @@
296296 $tables, $fields, $conds, $join_conds, $query_options, $opts['tagfilter']
297297 );
298298
299 - wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );
 299+ if ( !wfRunHooks( 'SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts, &$query_options ) ) )
 300+ return false;
300301
301302 // Don't use the new_namespace_time timestamp index if:
302303 // (a) "All namespaces" selected
Index: trunk/phase3/RELEASE-NOTES
@@ -312,6 +312,8 @@
313313 restrict/expand it.
314314 * (bug 21936) When a revision has been patrolled, there's now a link back to the
315315 article
 316+* (bug 22315) SpecialRecentChangesQuery hook now pass $query_options and checks
 317+ the return value
316318
317319 === Bug fixes in 1.16 ===
318320

Status & tagging log