r61651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61650‎ | r61651 | r61652 >
Date:00:51, 29 January 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fix careless errors in r61442 and r61444.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllmessages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllmessages.php
@@ -77,9 +77,10 @@
7878 $result = $this->getResult();
7979 foreach ( $messages_target as $message ) {
8080 // Skip all messages up to $params['from']
81 - if ( $skip && $message === $params['from'] ) {
 81+ if ( $skip && $message === $params['from'] )
8282 $skip = false;
8383
 84+ if ( !$skip ) {
8485 $a = array( 'name' => $message );
8586 $msg = wfMsgGetKey( $message, true, false, false );
8687 if ( wfEmptyMsg( $message, $msg ) )
@@ -148,4 +149,4 @@
149150 public function getVersion() {
150151 return __CLASS__ . ': $Id$';
151152 }
152 -}
\ No newline at end of file
 153+}
Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -541,7 +541,7 @@
542542 ' 1) Get data about a set of pages (last revision), by setting titles or pageids parameter.',
543543 ' 2) Get revisions for one given page, by using titles/pageids with start/end/limit params.',
544544 ' 3) Get data about a set of revisions by setting their IDs with revids parameter.',
545 - 'All parameters marked as (enum) may only be used with a single page (//2).'
 545+ 'All parameters marked as (enum) may only be used with a single page (#2).'
546546 );
547547 }
548548

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61442More of r61437 (adding/removing whitespace)reedy22:47, 23 January 2010
r61444Normalise comment usage (# --> //)reedy22:52, 23 January 2010

Status & tagging log