r61639 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61638‎ | r61639 | r61640 >
Date:16:22, 28 January 2010
Author:demon
Status:deferred
Tags:
Comment:
Drop needless freeResult() call, use getTitle() so we get a localized title object for this page
Modified paths:
  • /trunk/extensions/LastUserLogin/LastUserLogin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LastUserLogin/LastUserLogin_body.php
@@ -69,7 +69,7 @@
7070
7171 $out = '<table width="100%" cellpadding="3" ' . $style . '><tr>';
7272
73 - $title = Title::makeTitle( NS_SPECIAL, 'LastUserLogin' );
 73+ $title = $this->getTitle();
7474
7575 foreach ( $fields as $key => $value ) {
7676 $out .= '<th ' . $style . '><a href="' . $title->escapeLocalURL( array("order_by"=>$key, "order_type"=>$ordertype) ) . '">' . wfMsg( $value ) . '</a></th>';
@@ -98,7 +98,6 @@
9999 }
100100 $out .= '</tr>';
101101 }
102 - $dbr->freeResult($res);
103102 }
104103
105104 $out .= '</table>';

Status & tagging log