r61604 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61603‎ | r61604 | r61605 >
Date:20:48, 27 January 2010
Author:grondin
Status:ok (Comments)
Tags:
Comment:
Fixed wrong call pr_renderPageList() function (ProofReadPage extension)
Fixed wrong call renderQuiz() function (Quiz extension)
Correcting third parameter (as not a reference)
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)
  • /trunk/extensions/Quiz/Quiz.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Quiz/Quiz.php
@@ -75,7 +75,7 @@
7676 *
7777 * @return An HTML quiz.
7878 */
79 -function renderQuiz($input, $argv, &$parser) {
 79+function renderQuiz($input, $argv, $parser) {
8080 $parser->disableCache();
8181 $quiz = new Quiz($argv, $parser);
8282 return $quiz->parseQuiz($input);
Index: trunk/extensions/ProofreadPage/ProofreadPage.php
@@ -653,7 +653,7 @@
654654 * Parser hook for index pages
655655 * Display a list of coloured links to pages
656656 */
657 -function pr_renderPageList( $input, $args, &$parser ) {
 657+function pr_renderPageList( $input, $args, $parser ) {
658658 global $wgUser;
659659
660660 $page_namespace = pr_page_ns();

Comments

#Comment by Grondin (talk | contribs)   20:53, 27 January 2010

See for the same problem r61252

Status & tagging log