r61549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61548‎ | r61549 | r61550 >
Date:01:18, 27 January 2010
Author:adam
Status:deferred
Tags:
Comment:
RTL Dialog changes
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.dialogs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
——@@ -22,18 +22,18 @@
2323 array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 7 ),
2424 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 1 ),
2525 array( 'src' => 'css/wikiEditor.css', 'version' => 8 ),
26 - array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 14 ),
 26+ array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 15 ),
2727 array( 'src' => 'css/wikiEditor.preview.css', 'version' => 1 ),
2828 array( 'src' => 'css/wikiEditor.toc.css', 'version' => 28 ),
2929 array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 10 ),
3030 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3131 ),
3232 'combined' => array(
33 - array( 'src' => 'css/combined.css', 'version' => 57 ),
 33+ array( 'src' => 'css/combined.css', 'version' => 58 ),
3434 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3535 ),
3636 'minified' => array(
37 - array( 'src' => 'css/combined.min.css', 'version' => 57 ),
 37+ array( 'src' => 'css/combined.min.css', 'version' => 58 ),
3838 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3939 ),
4040 )
Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.dialogs.css
——@@ -86,8 +86,8 @@
8787 .ui-dialog-content input[type="checkbox"] {
8888 margin-left: 0;
8989 }
90 -.ui-dialog .ui-dialog-titlebar-close {
91 - right: 0.9em !important;
 90+body.ltr .ui-dialog .ui-dialog-titlebar-close {
 91+ right: 0.9em;
9292 }
9393 .wikieditor-toolbar-field-wrapper {
9494 padding: 0 0 25px 0;
——@@ -105,11 +105,21 @@
106106 padding: 0;
107107 float: left;
108108 }
 109+body.rtl #wikieditor-toolbar-table-dialog fieldset {
 110+ float: right;
 111+}
109112 #wikieditor-toolbar-table-dialog .wikieditor-toolbar-table-preview-wrapper {
110113 width: 330px;
111114 padding: 0;
112115 float: right;
113116 }
 117+body.rtl #wikieditor-toolbar-table-dialog .wikieditor-toolbar-table-preview-wrapper {
 118+ float: left;
 119+}
 120+body.rtl .ui-widget .wikieditor-toolbar-table-preview-wrapper table {
 121+ margin-left: 1em;
 122+ margin-right: 0;
 123+}
114124 .wikieditor-toolbar-table-preview-content * {
115125 cursor: default;
116126 }
——@@ -128,6 +138,11 @@
129139 margin-right: 20px;
130140 vertical-align: bottom;
131141 }
 142+body.rtl .wikieditor-toolbar-table-dimension-fields .wikieditor-toolbar-field-wrapper {
 143+ float: right;
 144+ margin-right: 0px;
 145+ margin-left: 20px;
 146+}
132147 .ui-dialog .ui-dialog-content {
133148 padding: 30px 20px 0 !important;
134149 }
——@@ -139,10 +154,10 @@
140155 /* RTL Changes */
141156 body.rtl .ui-dialog .ui-dialog-buttonpane button {
142157 float: left;
143 - margin: 0.5em 0.4 0.5em 0em !important;
 158+ margin: 0.5em 0.4em 0.5em 0 !important;
144159 }
145160 body.rtl .ui-dialog .ui-dialog-titlebar-close {
146 - left: 0.75em;
 161+ left: 0.9em;
147162 right: auto;
148163 }
149164 body.rtl .ui-dialog .ui-dialog-title {
Index: trunk/extensions/UsabilityInitiative/css/combined.css
——@@ -310,8 +310,8 @@
311311 .ui-dialog-content input[type="checkbox"] {
312312 margin-left: 0;
313313 }
314 -.ui-dialog .ui-dialog-titlebar-close {
315 - right: 0.9em !important;
 314+body.ltr .ui-dialog .ui-dialog-titlebar-close {
 315+ right: 0.9em;
316316 }
317317 .wikieditor-toolbar-field-wrapper {
318318 padding: 0 0 25px 0;
——@@ -329,11 +329,21 @@
330330 padding: 0;
331331 float: left;
332332 }
 333+body.rtl #wikieditor-toolbar-table-dialog fieldset {
 334+ float: right;
 335+}
333336 #wikieditor-toolbar-table-dialog .wikieditor-toolbar-table-preview-wrapper {
334337 width: 330px;
335338 padding: 0;
336339 float: right;
337340 }
 341+body.rtl #wikieditor-toolbar-table-dialog .wikieditor-toolbar-table-preview-wrapper {
 342+ float: left;
 343+}
 344+body.rtl .ui-widget .wikieditor-toolbar-table-preview-wrapper table {
 345+ margin-left: 1em;
 346+ margin-right: 0;
 347+}
338348 .wikieditor-toolbar-table-preview-content * {
339349 cursor: default;
340350 }
——@@ -352,6 +362,11 @@
353363 margin-right: 20px;
354364 vertical-align: bottom;
355365 }
 366+body.rtl .wikieditor-toolbar-table-dimension-fields .wikieditor-toolbar-field-wrapper {
 367+ float: right;
 368+ margin-right: 0px;
 369+ margin-left: 20px;
 370+}
356371 .ui-dialog .ui-dialog-content {
357372 padding: 30px 20px 0 !important;
358373 }
——@@ -363,10 +378,10 @@
364379 /* RTL Changes */
365380 body.rtl .ui-dialog .ui-dialog-buttonpane button {
366381 float: left;
367 - margin: 0.5em 0.4 0.5em 0em !important;
 382+ margin: 0.5em 0.4em 0.5em 0 !important;
368383 }
369384 body.rtl .ui-dialog .ui-dialog-titlebar-close {
370 - left: 0.75em;
 385+ left: 0.9em;
371386 right: auto;
372387 }
373388 body.rtl .ui-dialog .ui-dialog-title {
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
——@@ -288,8 +288,8 @@
289289 .ui-dialog-content input[type="checkbox"]{
290290 margin-left:0;
291291 }
292 -.ui-dialog .ui-dialog-titlebar-close{
293 -right:0.9em !important;
 292+body.ltr .ui-dialog .ui-dialog-titlebar-close{
 293+right:0.9em;
294294 }
295295 .wikieditor-toolbar-field-wrapper{
296296 padding:0 0 25px 0;
——@@ -305,11 +305,21 @@
306306 padding:0;
307307 float:left;
308308 }
 309+body.rtl #wikieditor-toolbar-table-dialog fieldset{
 310+float:right;
 311+}
309312 #wikieditor-toolbar-table-dialog .wikieditor-toolbar-table-preview-wrapper{
310313 width:330px;
311314 padding:0;
312315 float:right;
313316 }
 317+body.rtl #wikieditor-toolbar-table-dialog .wikieditor-toolbar-table-preview-wrapper{
 318+float:left;
 319+}
 320+body.rtl .ui-widget .wikieditor-toolbar-table-preview-wrapper table{
 321+margin-left:1em;
 322+margin-right:0;
 323+}
314324 .wikieditor-toolbar-table-preview-content *{
315325 cursor:default;
316326 }
——@@ -328,6 +338,11 @@
329339 margin-right:20px;
330340 vertical-align:bottom;
331341 }
 342+body.rtl .wikieditor-toolbar-table-dimension-fields .wikieditor-toolbar-field-wrapper{
 343+float:right;
 344+margin-right:0px;
 345+margin-left:20px;
 346+}
332347 .ui-dialog .ui-dialog-content{
333348 padding:30px 20px 0 !important;
334349 }
——@@ -336,10 +351,10 @@
337352 }
338353 body.rtl .ui-dialog .ui-dialog-buttonpane button{
339354 float:left;
340 -margin:0.5em 0.4 0.5em 0em !important;
 355+margin:0.5em 0.4em 0.5em 0 !important;
341356 }
342357 body.rtl .ui-dialog .ui-dialog-titlebar-close{
343 -left:0.75em;
 358+left:0.9em;
344359 right:auto;
345360 }
346361 body.rtl .ui-dialog .ui-dialog-title{

Status & tagging log