r61547 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r61546‎ \| r61547 \| r61548 >
Date:	01:03, 27 January 2010
Author:	adam
Status:	deferred
Tags:
Comment:	RTL changes for collapsedNav
Modified paths:	/trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history) /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history) /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history) /trunk/extensions/UsabilityInitiative/css/vector.collapsibleNav.css (modified) (history) /trunk/extensions/UsabilityInitiative/images/vector/collapsibleNav/arrow-left.png (added) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
—	—	@@ -19,7 +19,7 @@
20	20	'base_sets' => array(
21	21	'raw' => array(
22	22	array( 'src' => 'css/suggestions.css', 'version' => 6 ),
23		~~- array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 6 ),~~
	23	+ array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 7 ),
24	24	array( 'src' => 'css/vector.footerCleanup.css', 'version' => 1 ),
25	25	array( 'src' => 'css/wikiEditor.css', 'version' => 8 ),
26	26	array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 14 ),
—	—	@@ -29,11 +29,11 @@
30	30	array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
31	31	),
32	32	'combined' => array(
33		~~- array( 'src' => 'css/combined.css', 'version' => 56 ),~~
	33	+ array( 'src' => 'css/combined.css', 'version' => 57 ),
34	34	array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
35	35	),
36	36	'minified' => array(
37		~~- array( 'src' => 'css/combined.min.css', 'version' => 56 ),~~
	37	+ array( 'src' => 'css/combined.min.css', 'version' => 57 ),
38	38	array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
39	39	),
40	40	)
Index: trunk/extensions/UsabilityInitiative/images/vector/collapsibleNav/arrow-left.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/UsabilityInitiative/images/vector/collapsibleNav/arrow-left.png
___________________________________________________________________
Name: svn:mime-type
41	41	+ application/octet-stream
Index: trunk/extensions/UsabilityInitiative/css/vector.collapsibleNav.css
—	—	@@ -6,6 +6,10 @@
7	7	padding: 0.25em 0 !important;
8	8	margin: -11px 9px 10px 11px;
9	9	}
	10	+body.rtl #panel.collapsible-nav div.portal {
	11	+ background-position: right top;
	12	+ margin: -11px 11px 10px 9px;
	13	+}
10	14	#panel.collapsible-nav div.portal h5 {
11	15	color: #4D4D4D;
12	16	font-weight: normal;
—	—	@@ -13,11 +17,18 @@
14	18	padding: 4px 0 3px 1.5em;
15	19	margin-bottom: 0px;
16	20	}
	21	+body.rtl #panel.collapsible-nav div.portal h5 {
	22	+ background: url(../images/vector/collapsibleNav/arrow-down.png) 100% 50% no-repeat;
	23	+ padding: 4px 1.5em 3px 0;
	24	+}
17	25	#panel.collapsible-nav div.collapsed h5 {
18	26	color: #0645AD;
19	27	background: url(../images/vector/collapsibleNav/arrow-right.png) 0 50% no-repeat;
20	28	margin-bottom: 0px;
21	29	}
	30	+body.rtl #panel.collapsible-nav div.collapsed h5 {
	31	+ background: url(../images/vector/collapsibleNav/arrow-left.png) 100% 50% no-repeat;
	32	+}
22	33	#panel.collapsible-nav div h5:hover {
23	34	cursor: pointer;
24	35	text-decoration: none;
—	—	@@ -42,6 +53,10 @@
43	54	#panel.collapsible-nav #p-navigation div.body {
44	55	margin-left: 0.5em;
45	56	}
	57	+body.rtl #panel.collapsible-nav #p-navigation div.body {
	58	+ margin-left: 0;
	59	+ margin-right: 0.5em;
	60	+}
46	61	#panel.collapsible-nav #p-navigation h5 {
47	62	display: none;
48	63	}
Index: trunk/extensions/UsabilityInitiative/css/combined.css
—	—	@@ -57,6 +57,10 @@
58	58	padding: 0.25em 0 !important;
59	59	margin: -11px 9px 10px 11px;
60	60	}
	61	+body.rtl #panel.collapsible-nav div.portal {
	62	+ background-position: right top;
	63	+ margin: -11px 11px 10px 9px;
	64	+}
61	65	#panel.collapsible-nav div.portal h5 {
62	66	color: #4D4D4D;
63	67	font-weight: normal;
—	—	@@ -64,11 +68,18 @@
65	69	padding: 4px 0 3px 1.5em;
66	70	margin-bottom: 0px;
67	71	}
	72	+body.rtl #panel.collapsible-nav div.portal h5 {
	73	+ background: url(../images/vector/collapsibleNav/arrow-down.png) 100% 50% no-repeat;
	74	+ padding: 4px 1.5em 3px 0;
	75	+}
68	76	#panel.collapsible-nav div.collapsed h5 {
69	77	color: #0645AD;
70	78	background: url(../images/vector/collapsibleNav/arrow-right.png) 0 50% no-repeat;
71	79	margin-bottom: 0px;
72	80	}
	81	+body.rtl #panel.collapsible-nav div.collapsed h5 {
	82	+ background: url(../images/vector/collapsibleNav/arrow-left.png) 100% 50% no-repeat;
	83	+}
73	84	#panel.collapsible-nav div h5:hover {
74	85	cursor: pointer;
75	86	text-decoration: none;
—	—	@@ -93,6 +104,10 @@
94	105	#panel.collapsible-nav #p-navigation div.body {
95	106	margin-left: 0.5em;
96	107	}
	108	+body.rtl #panel.collapsible-nav #p-navigation div.body {
	109	+ margin-left: 0;
	110	+ margin-right: 0.5em;
	111	+}
97	112	#panel.collapsible-nav #p-navigation h5 {
98	113	display: none;
99	114	}
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
—	—	@@ -54,6 +54,10 @@
55	55	padding:0.25em 0 !important;
56	56	margin:-11px 9px 10px 11px;
57	57	}
	58	+body.rtl #panel.collapsible-nav div.portal{
	59	+background-position:right top;
	60	+margin:-11px 11px 10px 9px;
	61	+}
58	62	#panel.collapsible-nav div.portal h5{
59	63	color:#4D4D4D;
60	64	font-weight:normal;
—	—	@@ -61,11 +65,18 @@
62	66	padding:4px 0 3px 1.5em;
63	67	margin-bottom:0px;
64	68	}
	69	+body.rtl #panel.collapsible-nav div.portal h5{
	70	+background:url(../images/vector/collapsibleNav/arrow-down.png) 100% 50% no-repeat;
	71	+padding:4px 1.5em 3px 0;
	72	+}
65	73	#panel.collapsible-nav div.collapsed h5{
66	74	color:#0645AD;
67	75	background:url(../images/vector/collapsibleNav/arrow-right.png) 0 50% no-repeat;
68	76	margin-bottom:0px;
69	77	}
	78	+body.rtl #panel.collapsible-nav div.collapsed h5{
	79	+background:url(../images/vector/collapsibleNav/arrow-left.png) 100% 50% no-repeat;
	80	+}
70	81	#panel.collapsible-nav div h5:hover{
71	82	cursor:pointer;
72	83	text-decoration:none;
—	—	@@ -90,6 +101,10 @@
91	102	#panel.collapsible-nav #p-navigation div.body{
92	103	margin-left:0.5em;
93	104	}
	105	+body.rtl #panel.collapsible-nav #p-navigation div.body{
	106	+margin-left:0;
	107	+margin-right:0.5em;
	108	+}
94	109	#panel.collapsible-nav #p-navigation h5{
95	110	display:none;
96	111	}

Status & tagging log

11:10, 22 February 2010 Tim Starling (talk | contribs) changed the status of r61547 [removed: new added: deferred]