r61539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61538‎ | r61539 | r61540 >
Date:22:56, 26 January 2010
Author:adam
Status:deferred
Tags:
Comment:
Removing the table layout on the search and replace dialog, and a small whitespace cleanup on the footercleanup code
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Vector/Modules/FooterCleanup/FooterCleanup.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Modules/FooterCleanup/FooterCleanup.js
@@ -49,7 +49,7 @@
5050 // FIXME: i18n, remove link from message and let community add link to transclusion page if it exists
5151 .prepend( '<label>This page contains <a href="http://en.wikipedia.org/wiki/transclusion">transclusions</a> of <strong>'
5252 + transclusionCount
53 - + '</strong> other pages.</label>');
 53+ + '</strong> other pages.</label>' );
5454 $j( '.mw-templatesUsedExplanation' ).remove();
5555
5656 $j( '.collapsible-list label' )
@@ -67,5 +67,5 @@
6868 .remove();
6969 $j( '#mw-editform-cancel' )
7070 .remove()
71 - .appendTo('.editButtons');
 71+ .appendTo( '.editButtons' );
7272 } );
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -15,14 +15,14 @@
1616 array( 'src' => 'Modules/CollapsibleNav/CollapsibleNav.js', 'version' => 6 ),
1717 array( 'src' => 'Modules/CollapsibleTabs/CollapsibleTabs.js', 'version' => 6 ),
1818 array( 'src' => 'Modules/EditWarning/EditWarning.js', 'version' => 5 ),
19 - array( 'src' => 'Modules/FooterCleanup/FooterCleanup.js', 'version' => 3 ),
 19+ array( 'src' => 'Modules/FooterCleanup/FooterCleanup.js', 'version' => 4 ),
2020 array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 6 ),
2121 ),
2222 'combined' => array(
23 - array( 'src' => 'Vector.combined.js', 'version' => 17 ),
 23+ array( 'src' => 'Vector.combined.js', 'version' => 18 ),
2424 ),
2525 'minified' => array(
26 - array( 'src' => 'Vector.combined.min.js', 'version' => 17 ),
 26+ array( 'src' => 'Vector.combined.min.js', 'version' => 18 ),
2727 ),
2828 );
2929 static $modules = array(
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -212,7 +212,7 @@
213213 // FIXME: i18n, remove link from message and let community add link to transclusion page if it exists
214214 .prepend( '<label>This page contains <a href="http://en.wikipedia.org/wiki/transclusion">transclusions</a> of <strong>'
215215 + transclusionCount
216 - + '</strong> other pages.</label>');
 216+ + '</strong> other pages.</label>' );
217217 $j( '.mw-templatesUsedExplanation' ).remove();
218218
219219 $j( '.collapsible-list label' )
@@ -230,7 +230,7 @@
231231 .remove();
232232 $j( '#mw-editform-cancel' )
233233 .remove()
234 - .appendTo('.editButtons');
 234+ .appendTo( '.editButtons' );
235235 } );
236236 /* JavaScript for SimpleSearch extension */
237237
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -35,7 +35,7 @@
3636 array(
3737 'src' => 'Modules/Toolbar/Toolbar.js',
3838 'class' => 'wikiEditor.config.toolbar',
39 - 'version' => 34
 39+ 'version' => 35
4040 ),
4141 array(
4242 'src' => 'Modules/TemplateEditor/TemplateEditor.js',
@@ -44,10 +44,10 @@
4545 ),
4646 ),
4747 'combined' => array(
48 - array( 'src' => 'WikiEditor.combined.js', 'version' => 36 ),
 48+ array( 'src' => 'WikiEditor.combined.js', 'version' => 37 ),
4949 ),
5050 'minified' => array(
51 - array( 'src' => 'WikiEditor.combined.min.js', 'version' => 36 ),
 51+ array( 'src' => 'WikiEditor.combined.min.js', 'version' => 37 ),
5252 ),
5353 );
5454 static $messages = array(
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js
@@ -1692,19 +1692,24 @@
16931693 <div id="wikieditor-toolbar-replace-emptysearch" rel="wikieditor-toolbar-tool-replace-emptysearch"></div>\
16941694 <div id="wikieditor-toolbar-replace-invalidregex"></div>\
16951695 </div>\
1696 - <fieldset><table width="100%"><tr>\
1697 - <td width="25%"><label for="wikieditor-toolbar-replace-search" rel="wikieditor-toolbar-tool-replace-search"></label></td>\
1698 - <td width="75%"><input type="text" id="wikieditor-toolbar-replace-search" style="width: 90%;" /></td>\
1699 - </tr><tr>\
1700 - <td><label for="wikieditor-toolbar-replace-replace" rel="wikieditor-toolbar-tool-replace-replace"></label></td>\
1701 - <td><input type="text" id="wikieditor-toolbar-replace-replace" style="width: 90%;" /></td>\
1702 - </tr></table><table><tr>\
1703 - <td><input type="checkbox" id="wikieditor-toolbar-replace-case" /></td>\
1704 - <td><label for="wikieditor-toolbar-replace-case" rel="wikieditor-toolbar-tool-replace-case"></label></td>\
1705 - </tr><tr>\
1706 - <td><input type="checkbox" id="wikieditor-toolbar-replace-regex" /></td>\
1707 - <td><label for="wikieditor-toolbar-replace-regex" rel="wikieditor-toolbar-tool-replace-regex"></label></td>\
1708 - </tr></table></fieldset>',
 1696+ <fieldset>\
 1697+ <div class="wikieditor-toolbar-field-wrapper">\
 1698+ <label for="wikieditor-toolbar-replace-search" rel="wikieditor-toolbar-tool-replace-search"></label>\
 1699+ <input type="text" id="wikieditor-toolbar-replace-search" style="width: 100%;" />\
 1700+ </div>\
 1701+ <div class="wikieditor-toolbar-field-wrapper">\
 1702+ <label for="wikieditor-toolbar-replace-replace" rel="wikieditor-toolbar-tool-replace-replace"></label>\
 1703+ <input type="text" id="wikieditor-toolbar-replace-replace" style="width: 100%;" />\
 1704+ </div>\
 1705+ <div class="wikieditor-toolbar-field-wrapper">\
 1706+ <input type="checkbox" id="wikieditor-toolbar-replace-case" />\
 1707+ <label for="wikieditor-toolbar-replace-case" rel="wikieditor-toolbar-tool-replace-case"></label>\
 1708+ </div>\
 1709+ <div class="wikieditor-toolbar-field-wrapper">\
 1710+ <input type="checkbox" id="wikieditor-toolbar-replace-regex" />\
 1711+ <label for="wikieditor-toolbar-replace-regex" rel="wikieditor-toolbar-tool-replace-regex"></label>\
 1712+ </div>\
 1713+ </fieldset>',
17091714 init: function() {
17101715 $j(this).find( '[rel]' ).each( function() {
17111716 $j(this).text( gM( $j(this).attr( 'rel' ) ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r61548UsabilityInitiative: Performance fixes for TOC building...catrope01:12, 27 January 2010

Status & tagging log