r61516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61515‎ | r61516 | r61517 >
Date:13:40, 26 January 2010
Author:demon
Status:ok
Tags:
Comment:
Inform user of parsekit/php -l usage, fix line breaks in output
Modified paths:
  • /trunk/phase3/maintenance/syntaxChecker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/syntaxChecker.php
@@ -49,7 +49,9 @@
5050 // ParseKit is broken on PHP 5.3+, disabled until this is fixed
5151 $useParseKit = function_exists( 'parsekit_compile_file' ) && version_compare( PHP_VERSION, '5.3', '<' );
5252
53 - $this->output( "Checking syntax (this can take a really long time)...\n\n" );
 53+ $str = 'Checking syntax (using ' . ( $useParseKit ?
 54+ 'parsekit)' : ' php -l, this can take a long time)' );
 55+ $this->output( $str );
5456 foreach( $this->mFiles as $f ) {
5557 if( $useParseKit ) {
5658 $this->checkFileWithParsekit( $f );
@@ -127,7 +129,7 @@
128130 return;
129131 }
130132
131 - $this->output( "Building file list..." );
 133+ $this->output( 'Building file list...', 'listfiles' );
132134
133135 // Only check files in these directories.
134136 // Don't just put $IP, because the recursive dir thingie goes into all subdirs
@@ -154,7 +156,7 @@
155157 $this->mFiles[] = "$IP/AdminSettings.php";
156158 }
157159
158 - $this->output( "done.\n" );
 160+ $this->output( 'done.', 'listfiles' );
159161 }
160162
161163 /**

Status & tagging log