r61432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61431‎ | r61432 | r61433 >
Date:20:15, 23 January 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Use Html::element instead of Xml::element

It produces nicer output and has no braindeadiness with empty contents
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -129,12 +129,11 @@
130130 $path = "{$wgStylePath}/common/{$file}";
131131 }
132132 $this->addScript(
133 - Xml::element( 'script',
 133+ Html::element( 'script',
134134 array(
135135 'type' => $wgJsMimeType,
136136 'src' => "$path?$wgStyleVersion",
137 - ),
138 - '', false
 137+ )
139138 )
140139 );
141140 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r61472Use Html::linkedScript()...simetrical19:43, 24 January 2010

Status & tagging log