r61417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61416‎ | r61417 | r61418 >
Date:15:24, 23 January 2010
Author:ialex
Status:ok
Tags:
Comment:
* $fname -> __METHOD__
* some style fixes
Modified paths:
  • /trunk/phase3/includes/parser/ParserOptions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/ParserOptions.php
@@ -5,8 +5,7 @@
66 * @todo document
77 * @ingroup Parser
88 */
9 -class ParserOptions
10 -{
 9+class ParserOptions {
1110 # All variables are supposed to be private in theory, although in practise this is not the case.
1211 var $mUseTeX; # Use texvc to expand <math> tags
1312 var $mUseDynamicDates; # Use DateFormatter to format dates
@@ -35,7 +34,7 @@
3635 var $mUser; # Stored user object, just used to initialise the skin
3736 var $mIsPreview; # Parsing the page for a "preview" operation
3837 var $mIsSectionPreview; # Parsing the page for a "preview" operation on a single section
39 - var $mIsPrintable; # Parsing the printable version of the page
 38+ var $mIsPrintable; # Parsing the printable version of the page
4039
4140 function getUseTeX() { return $this->mUseTeX; }
4241 function getUseDynamicDates() { return $this->mUseDynamicDates; }
@@ -127,8 +126,9 @@
128127 global $wgAllowExternalImagesFrom, $wgEnableImageWhitelist, $wgAllowSpecialInclusion, $wgMaxArticleSize;
129128 global $wgMaxPPNodeCount, $wgMaxTemplateDepth, $wgMaxPPExpandDepth, $wgCleanSignatures;
130129 global $wgExternalLinkTarget;
131 - $fname = 'ParserOptions::initialiseFromUser';
132 - wfProfileIn( $fname );
 130+
 131+ wfProfileIn( __METHOD__ );
 132+
133133 if ( !$userInput ) {
134134 global $wgUser;
135135 if ( isset( $wgUser ) ) {
@@ -167,6 +167,7 @@
168168 $this->mExternalLinkTarget = $wgExternalLinkTarget;
169169 $this->mIsPreview = false;
170170 $this->mIsSectionPreview = false;
171 - wfProfileOut( $fname );
 171+
 172+ wfProfileOut( __METHOD__ );
172173 }
173174 }

Status & tagging log