r61350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61349‎ | r61350 | r61351 >
Date:02:00, 22 January 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.5.3
* Fixed bug in Yahoo! Maps form input
Modified paths:
  • /trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayersFunctions.js (modified) (history)
  • /trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php
@@ -74,7 +74,7 @@
7575 <div id='".$this->mapName."' style='width: {$this->width}px; height: {$this->height}px;'></div>
7676
7777 <script type='$wgJsMimeType'>/*<![CDATA[*/
78 - addOnloadHook(makeFormInputYahooMap('$this->mapName', '$this->coordsFieldName', $this->centre_lat, $this->centre_lon, $this->zoom, $type, [$typesString], [$this->controls], $this->autozoom, $this->marker_lat, $this->centre_lon, $this->height));
 78+ addOnloadHook(makeFormInputYahooMap('$this->mapName', '$this->coordsFieldName', $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$this->$types], [$this->controls], $this->autozoom, $this->marker_lat, $this->centre_lon, $this->height));
7979 /*]]>*/</script>";
8080 }
8181
Index: trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayersFunctions.js
@@ -60,7 +60,7 @@
6161 if (!window.OLMaps) window.OLMaps = new Object;
6262 eval("window.OLMaps." + mapName + " = map;");
6363 }
64 -
 64+
6565 /**
6666 * Remove all markers from an OL map (that's in window.OLMaps), and place a new one.
6767 *
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if (defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' )) {
39 - define('SM_VERSION', '0.5.3 a1');
 39+ define('SM_VERSION', '0.5.3 a2');
4040
4141 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
4242 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php
@@ -22,7 +22,6 @@
2323 */
2424 public static function initialize() {
2525 global $smgIP, $wgAutoloadClasses, $egMapsServices;
26 -
2726 $wgAutoloadClasses['SMMapPrinter'] = $smgIP . '/QueryPrinters/SM_MapPrinter.php';
2827
2928 self::initializeParams();

Status & tagging log