r61344 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61343‎ | r61344 | r61345 >
Date:23:12, 21 January 2010
Author:tparscal
Status:ok
Tags:
Comment:
A line added in r61308 is causing bug 22205.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -35,7 +35,7 @@
3636 array(
3737 'src' => 'Modules/Toolbar/Toolbar.js',
3838 'class' => 'wikiEditor.config.toolbar',
39 - 'version' => 22
 39+ 'version' => 23
4040 ),
4141 array(
4242 'src' => 'Modules/TemplateEditor/TemplateEditor.js',
@@ -44,10 +44,10 @@
4545 ),
4646 ),
4747 'combined' => array(
48 - array( 'src' => 'WikiEditor.combined.js', 'version' => 23 ),
 48+ array( 'src' => 'WikiEditor.combined.js', 'version' => 24 ),
4949 ),
5050 'minified' => array(
51 - array( 'src' => 'WikiEditor.combined.min.js', 'version' => 23 ),
 51+ array( 'src' => 'WikiEditor.combined.min.js', 'version' => 24 ),
5252 ),
5353 );
5454 static $messages = array(
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js
@@ -1237,7 +1237,8 @@
12381238 .val( $j( this ).prev( 'label' ).text() )
12391239 .addClass( 'wikieditor-toolbar-dialog-hint' );
12401240 })
1241 - .trigger( 'focus' )
 1241+ // FIXME: this is causing scroll to bottom on load
 1242+ //.trigger( 'focus' )
12421243 .prev( 'label' )
12431244 .css( 'display', 'none' );
12441245
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.min.js
@@ -42,7 +42,7 @@
4343 cache[target]=status;updateWidget(status);}}));}
4444 $j(this).find('[rel]').each(function(){$j(this).text(gM($j(this).attr('rel')));});$j('#wikieditor-toolbar-link-int-target, #wikieditor-toolbar-link-int-text').focus(function(){if($j(this).val()==$j(this).prev('label').text())
4545 $j(this).val('').removeClass('wikieditor-toolbar-dialog-hint');}).bind('blur change',function(){if($j(this).val()=='')
46 -$j(this).val($j(this).prev('label').text()).addClass('wikieditor-toolbar-dialog-hint');}).trigger('focus').prev('label').css('display','none');$j('#wikieditor-toolbar-link-int-target').bind('change keydown paste cut',function(){setTimeout(function(){if(isExternalLink($j('#wikieditor-toolbar-link-int-target').val()))
 46+$j(this).val($j(this).prev('label').text()).addClass('wikieditor-toolbar-dialog-hint');}).prev('label').css('display','none');$j('#wikieditor-toolbar-link-int-target').bind('change keydown paste cut',function(){setTimeout(function(){if(isExternalLink($j('#wikieditor-toolbar-link-int-target').val()))
4747 $j('#wikieditor-toolbar-link-type-ext').attr('checked','checked');else
4848 $j('#wikieditor-toolbar-link-type-int').attr('checked','checked');if($j('#wikieditor-toolbar-link-int-text').data('untouched'))
4949 $j('#wikieditor-toolbar-link-int-text').val($j('#wikieditor-toolbar-link-int-target').val()).change();},0);});$j('#wikieditor-toolbar-link-int-text').bind('change keydown paste cut',function(){var oldVal=$j(this).val();var that=this;setTimeout(function(){if($j(that).val()!=oldVal)
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js
@@ -1156,7 +1156,8 @@
11571157 .val( $j( this ).prev( 'label' ).text() )
11581158 .addClass( 'wikieditor-toolbar-dialog-hint' );
11591159 })
1160 - .trigger( 'focus' )
 1160+ // FIXME: this is causing scroll to bottom on load
 1161+ //.trigger( 'focus' )
11611162 .prev( 'label' )
11621163 .css( 'display', 'none' );
11631164

Follow-up revisions

RevisionCommit summaryAuthorDate
r61383Follow up to r61308 that addresses bug 22205 without losing any functionality.adam19:50, 22 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61308Insert dialog updates. No more table, better input hintsadam21:14, 20 January 2010

Status & tagging log