r61334 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61333‎ | r61334 | r61335 >
Date:15:45, 21 January 2010
Author:siebrand
Status:deferred
Tags:
Comment:
* Quote $1 in 'recordadmin-notset'; appears to be an arbitrary string of one or more field names.
* Minor style updates
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.i18n.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -495,11 +495,15 @@
496496 $td = "<td colspan=\"$ncol\">";
497497 $tmp = array();
498498 foreach( $records as $k1 => $v1 ) {
499 - if ( empty( $k1 ) ) $k1 = wfMsg( 'recordadmin-notset', $groupby[0] );
 499+ if ( empty( $k1 ) ) {
 500+ $k1 = wfMsg( 'recordadmin-notset', $groupby[0] );
 501+ }
500502 $tmp[] = "$td<h2>$k1</h2></td>\n";
501503 foreach( $v1 as $k2 => $v2 ) {
502504 if ( isset( $groupby[1] ) ) {
503 - if ( empty( $k2 ) ) $k2 = wfMsg( 'recordadmin-notset', $groupby[1] );
 505+ if ( empty( $k2 ) ) {
 506+ $k2 = wfMsg( 'recordadmin-notset', $groupby[1] );
 507+ }
504508 $tmp[] = "$td<h3>$k2</h3></td>\n";
505509 foreach( $v2 as $v3 ) $tmp[] = $v3;
506510 } else $tmp[] = $v2;
Index: trunk/extensions/RecordAdmin/RecordAdmin.i18n.php
@@ -57,7 +57,7 @@
5858 'right-recordadmin' => 'Find and edit record pages',
5959 'recordadmin-export-csv' => 'CSV',
6060 'recordadmin-export-pdf' => 'PDF',
61 - 'recordadmin-notset' => 'No $1',
 61+ 'recordadmin-notset' => 'No "$1"',
6262 );
6363
6464 /** Message documentation (Message documentation)
@@ -87,6 +87,8 @@
8888 'right-recordadmin' => '{{doc-right|recordadmin}}',
8989 'recordadmin-export-csv' => '{{Optional}}',
9090 'recordadmin-export-pdf' => '{{Optional}}',
 91+ 'recordadmin-notset' => 'Parameters:
 92+* $1 is string of one or more comma separated field names.',
9193 );
9294
9395 /** Afrikaans (Afrikaans)

Status & tagging log