r61326 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61325‎ | r61326 | r61327 >
Date:07:45, 21 January 2010
Author:aaron
Status:resolved
Tags:
Comment:
Make sure that empty tags don't end up in the DB
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -555,11 +555,13 @@
556556 protected function tagData( $tags ) {
557557 $data = array();
558558 foreach ( $tags as $tag ) {
 559+ if( $tag == '' ) continue;
559560 $data[] = array(
560561 'ct_repo_id' => $this->mRepoId,
561562 'ct_rev_id' => $this->mId,
562563 'ct_tag' => $this->normalizeTag( $tag ) );
563564 }
 565+ var_dump( $tags ); moo();
564566 return $data;
565567 }
566568

Status & tagging log