r61318 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61317‎ | r61318 | r61319 >
Date:23:51, 20 January 2010
Author:mah
Status:ok
Tags:
Comment:
eol whitespace cleanups
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -193,7 +193,7 @@
194194 font-size: 85%;
195195 padding-top: 3em;
196196 }
197 -
 197+
198198 span.success-message {
199199 font-weight: bold;
200200 font-size: 110%;
@@ -208,7 +208,7 @@
209209 <script type="text/javascript">
210210 <!--
211211 <?php echo 'var databases = ' . FormatJson::encode( $ourdb ) . ';'; ?>
212 -
 212+
213213 function show(id, showOrHide) {
214214 var i = document.getElementById(id);
215215 if (i) i.style.display = showOrHide ? 'block' : 'none';
@@ -269,7 +269,7 @@
270270 cd <i>" . htmlspecialchars( dirname( dirname( __FILE__ ) ) ) . "</i>
271271 chmod a+w config
272272 </pre>
273 -
 273+
274274 <p>Afterwards retry to start the <a href=\"\">setup</a>.</p>" );
275275 }
276276
@@ -634,22 +634,22 @@
635635 $conf->LanguageCode = importPost( "LanguageCode", "en" );
636636 ## MySQL specific:
637637 $conf->DBprefix = importPost( "DBprefix" );
638 - $conf->setSchema(
639 - importPost( "DBschema", "mysql5-binary" ),
 638+ $conf->setSchema(
 639+ importPost( "DBschema", "mysql5-binary" ),
640640 importPost( "DBengine", "InnoDB" ) );
641641
642642 ## Postgres specific:
643643 $conf->DBport = importPost( "DBport", "5432" );
644644 $conf->DBts2schema = importPost( "DBts2schema", "public" );
645645 $conf->DBpgschema = importPost( "DBpgschema", "mediawiki" );
646 -
 646+
647647 ## SQLite specific
648648 $conf->SQLiteDataDir = importPost( "SQLiteDataDir", "" );
649 -
 649+
650650 ## MSSQL specific
651651 // We need a second field so it doesn't overwrite the MySQL one
652652 $conf->DBprefix2 = importPost( "DBprefix2" );
653 -
 653+
654654 ## DB2 specific:
655655 // New variable in order to have a different default port number
656656 $conf->DBport_db2 = importPost( "DBport_db2", "50000" );
@@ -792,7 +792,7 @@
793793 $local = writeLocalSettings( $conf );
794794 echo "<li style=\"list-style: none\">\n";
795795 echo "<p><b>Generating configuration file...</b></p>\n";
796 - echo "</li>\n";
 796+ echo "</li>\n";
797797
798798 $wgCommandLineMode = false;
799799 chdir( ".." );
@@ -848,14 +848,14 @@
849849
850850 ## DB2 specific:
851851 $wgDBcataloged = $conf->DBcataloged;
852 -
 852+
853853 $wgCommandLineMode = true;
854854 if (! defined ( 'STDERR' ) )
855855 define( 'STDERR', fopen("php://stderr", "wb"));
856856 $wgUseDatabaseMessages = false; /* FIXME: For database failure */
857857 require_once( "$IP/includes/Setup.php" );
858858 Language::getLocalisationCache()->disableBackend();
859 -
 859+
860860 chdir( "config" );
861861
862862 $wgTitle = Title::newFromText( "Installation script" );
@@ -937,14 +937,14 @@
938938 $db_user = $wgDBuser;
939939 $db_pass = $wgDBpassword;
940940 }
941 -
942 - echo( "<li>Attempting to connect to database \"" . htmlspecialchars( $wgDBname ) .
 941+
 942+ echo( "<li>Attempting to connect to database \"" . htmlspecialchars( $wgDBname ) .
943943 "\" as \"" . htmlspecialchars( $db_user ) . "\"..." );
944944 $wgDatabase = $dbc->newFromParams($wgDBserver, $db_user, $db_pass, $wgDBname, 1);
945945 // enable extra debug messages
946946 $dbc->setMode(DatabaseIbm_db2::INSTALL_MODE);
947947 $wgDatabase->setMode(DatabaseIbm_db2::INSTALL_MODE);
948 -
 948+
949949 if (!$wgDatabase->isOpen()) {
950950 print " error: " . htmlspecialchars( $wgDatabase->lastError() ) . "</li>\n";
951951 } else {
@@ -956,7 +956,7 @@
957957 if ("$wgSQLiteDataDir" == '') {
958958 $wgSQLiteDataDir = dirname($_SERVER['DOCUMENT_ROOT']).'/data';
959959 }
960 - echo '<li>Attempting to connect to SQLite database at "' .
 960+ echo '<li>Attempting to connect to SQLite database at "' .
961961 htmlspecialchars( $wgSQLiteDataDir ) . '": ';
962962 if ( !is_dir( $wgSQLiteDataDir ) ) {
963963 if ( is_writable( dirname( $wgSQLiteDataDir ) ) ) {
@@ -996,7 +996,7 @@
997997 echo 'error: ' . htmlspecialchars( $ex->getMessage() ) . "</li>\n";
998998 continue;
999999 }
1000 -
 1000+
10011001 if (!$wgDatabase->isOpen()) {
10021002 print "error: " . htmlspecialchars( $wgDatabase->lastError() ) . "</li>\n";
10031003 $errs['SQLiteDataDir'] = 'Could not connect to database';
@@ -1056,7 +1056,7 @@
10571057 // Changed !mysql to postgres check since it seems to only apply to postgres
10581058 if( $useRoot && $conf->DBtype == 'postgres' ) {
10591059 $wgDBsuperuser = $conf->RootUser;
1060 - echo( "<li>Attempting to connect to database \"postgres\" as superuser \"" .
 1060+ echo( "<li>Attempting to connect to database \"postgres\" as superuser \"" .
10611061 htmlspecialchars( $wgDBsuperuser ) . "\"..." );
10621062 $wgDatabase = $dbc->newFromParams($wgDBserver, $wgDBsuperuser, $conf->RootPW, "postgres", 1);
10631063 if (!$wgDatabase->isOpen()) {
@@ -1068,7 +1068,7 @@
10691069 }
10701070 $wgDatabase->initial_setup($conf->RootPW, 'postgres');
10711071 }
1072 - echo( "<li>Attempting to connect to database \"" . htmlspecialchars( $wgDBname ) .
 1072+ echo( "<li>Attempting to connect to database \"" . htmlspecialchars( $wgDBname ) .
10731073 "\" as \"" . htmlspecialchars( $wgDBuser ) . "\"..." );
10741074 $wgDatabase = $dbc->newFromParams($wgDBserver, $wgDBuser, $wgDBpassword, $wgDBname, 1);
10751075 if (!$wgDatabase->isOpen()) {
@@ -1081,7 +1081,7 @@
10821082 $myver = $wgDatabase->getServerVersion();
10831083 }
10841084 if (is_callable(array($wgDatabase, 'initial_setup'))) $wgDatabase->initial_setup('', $wgDBname);
1085 - }
 1085+ }
10861086
10871087 if ( !$wgDatabase->isOpen() ) {
10881088 $errs["DBserver"] = "Couldn't connect to database";
@@ -1178,7 +1178,7 @@
11791179 $encExisting = htmlspecialchars( $existingSchema );
11801180 $encRequested = htmlspecialchars( $conf->DBschema );
11811181 print "<li><strong>Warning:</strong> you requested the $encRequested schema, " .
1182 - "but the existing database has the $encExisting schema. This upgrade script ".
 1182+ "but the existing database has the $encExisting schema. This upgrade script ".
11831183 "can't convert it, so it will remain $encExisting.</li>\n";
11841184 $conf->setSchema( $existingSchema, $conf->DBengine );
11851185 }
@@ -1229,7 +1229,7 @@
12301230 }
12311231 $wgDatabase->freeResult( $res );
12321232 if ( !$found && $conf->DBengine != 'MyISAM' ) {
1233 - echo "<li><strong>Warning:</strong> " . htmlspecialchars( $conf->DBengine ) .
 1233+ echo "<li><strong>Warning:</strong> " . htmlspecialchars( $conf->DBengine ) .
12341234 " storage engine not available, " .
12351235 "using MyISAM instead</li>\n";
12361236 $conf->setSchema( $conf->DBschema, 'MyISAM' );
@@ -1250,8 +1250,8 @@
12511251 }
12521252
12531253 print " done.</li>\n";
1254 -
1255 -
 1254+
 1255+
12561256 if ( $conf->DBtype == 'ibm_db2' ) {
12571257 // Now that table creation is done, make sure everything is committed
12581258 // Do this before doing inserts through API
@@ -1496,7 +1496,7 @@
14971497 MediaWiki can also detect and support eAccelerator, Turck MMCache, APC, and XCache, but
14981498 these should not be used if the wiki will be running on multiple application servers.
14991499 <br /><br />
1500 - DBA (Berkeley-style DB) is generally slower than using no cache at all, and is only
 1500+ DBA (Berkeley-style DB) is generally slower than using no cache at all, and is only
15011501 recommended for testing.
15021502 </p>
15031503 </div>
@@ -1537,7 +1537,7 @@
15381538 <div class="config-desc">
15391539 <p>
15401540 For this feature to work, an e-mail address must be present for the user account, and the notification
1541 - options in the user's preferences must be enabled. Also note the
 1541+ options in the user's preferences must be enabled. Also note the
15421542 authentication option below. When testing the feature, keep in mind that your own changes will never trigger notifications to be sent to yourself.</p>
15431543
15441544 <p>There are additional options for fine tuning in /includes/DefaultSettings.php; copy these to your LocalSettings.php and edit them there to change them.</p>
@@ -1562,13 +1562,13 @@
15631563 <div class="config-section">
15641564 <div class="config-input">
15651565 <label class='column'>Database type:</label>
1566 -<?php
 1566+<?php
15671567 if (isset($errs['DBpicktype'])) {
15681568 print "\t<span class='error'>" . htmlspecialchars( $errs['DBpicktype'] ) . "</span>\n";
15691569 }
15701570 ?>
1571 - <ul class='plain'><?php
1572 - database_picker($conf);
 1571+ <ul class='plain'><?php
 1572+ database_picker($conf);
15731573 ?></ul>
15741574 </div>
15751575
@@ -1589,7 +1589,7 @@
15901590 <p class="config-desc">
15911591 If you only have a single user account and database available,
15921592 enter those here. If you have database root access (see below)
1593 - you can specify new accounts/databases to be created. This account
 1593+ you can specify new accounts/databases to be created. This account
15941594 will not be created if it pre-exists. If this is the case, ensure that it
15951595 has SELECT, INSERT, UPDATE, and DELETE permissions on the MediaWiki database.
15961596 </p>
@@ -1627,8 +1627,8 @@
16281628 </ul>
16291629 </div>
16301630 <p class="config-desc">
1631 - InnoDB is best for public web installations, since it has good concurrency
1632 - support. MyISAM may be faster in single-user installations. MyISAM databases
 1631+ InnoDB is best for public web installations, since it has good concurrency
 1632+ support. MyISAM may be faster in single-user installations. MyISAM databases
16331633 tend to get corrupted more often than InnoDB databases.
16341634 </p>
16351635 <div class="config-input"><label class="column">Database character set</label>
@@ -1640,7 +1640,7 @@
16411641 </ul>
16421642 </div>
16431643 <p class="config-desc">
1644 - This option is ignored on upgrade, the same character set will be kept.
 1644+ This option is ignored on upgrade, the same character set will be kept.
16451645 <br /><br />
16461646 <b>WARNING:</b> If you use <b>backwards-compatible UTF-8</b> on MySQL 4.1+, and subsequently back up the database with <tt>mysqldump</tt>, it may destroy all non-ASCII characters, irreversibly corrupting your backups!.
16471647 <br /><br />
@@ -1653,8 +1653,8 @@
16541654 <div class="config-input"><?php aField( $conf, "DBpgschema", "Schema for mediawiki:" ); ?></div>
16551655 <div class="config-input"><?php aField( $conf, "DBts2schema", "Schema for tsearch2:" ); ?></div>
16561656 <div class="config-desc">
1657 - <p>The username specified above (at "DB username") will have its search path set to the above schemas,
1658 - so it is recommended that you create a new user. The above schemas are generally correct:
 1657+ <p>The username specified above (at "DB username") will have its search path set to the above schemas,
 1658+ so it is recommended that you create a new user. The above schemas are generally correct:
16591659 only change them if you are sure you need to.</p>
16601660 </div>
16611661 </fieldset>
@@ -1667,7 +1667,7 @@
16681668 <p>SQLite stores table data into files in the filesystem.
16691669 If you do not provide an explicit path, a "data" directory in
16701670 the parent of your document root will be used.</p>
1671 -
 1671+
16721672 <p>This directory must exist and be writable by the web server.</p>
16731673 </div>
16741674 </fieldset>
@@ -1684,7 +1684,7 @@
16851685 <p>Avoid exotic characters; something like <tt>mw_</tt> is good.</p>
16861686 </div>
16871687 </fieldset>
1688 -
 1688+
16891689 <?php database_switcher('ibm_db2'); ?>
16901690 <div class="config-input"><?php
16911691 aField( $conf, "DBport_db2", "Database port:" );
@@ -1944,7 +1944,7 @@
19451945 \$wgScriptPath = \"{$slconf['ScriptPath']}\";
19461946 \$wgScriptExtension = \"{$slconf['ScriptExtension']}\";
19471947
1948 -## The relative URL path to the skins directory
 1948+## The relative URL path to the skins directory
19491949 \$wgStylePath = \"\$wgScriptPath/skins\";
19501950
19511951 ## The relative URL path to the logo. Make sure you change this from the default,

Status & tagging log