r61295 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61294‎ | r61295 | r61296 >
Date:15:59, 20 January 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.5.3
* Zoom levels fix: changed allowed ranges
Modified paths:
  • /trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/Maps_Mapper.php (modified) (history)
  • /trunk/extensions/Maps/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/OpenStreetMap/Maps_OSM.php (modified) (history)
  • /trunk/extensions/Maps/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/OpenLayers/Maps_OpenLayers.php
@@ -54,6 +54,7 @@
5555 global $egMapsServices, $egMapsOLLayers, $egMapsOLControls, $egMapsOpenLayersZoom;
5656
5757 $egMapsServices[self::SERVICE_NAME]['parameters']['default'] = $egMapsOpenLayersZoom;
 58+ $egMapsServices[self::SERVICE_NAME]['parameters']['zoom']['criteria']['in_range'] = array(0, 19);
5859
5960 $egMapsServices[self::SERVICE_NAME]['parameters'] = array(
6061 'controls' => array(
Index: trunk/extensions/Maps/OpenStreetMap/Maps_OSM.php
@@ -52,6 +52,7 @@
5353 global $egMapsServices, $egMapsOSMZoom, $egMapsOSMControls;
5454
5555 $egMapsServices[self::SERVICE_NAME]['parameters']['default'] = $egMapsOSMZoom;
 56+ $egMapsServices[self::SERVICE_NAME]['parameters']['zoom']['criteria']['in_range'] = array(0, 19);
5657
5758 $egMapsServices[self::SERVICE_NAME]['parameters'] = array(
5859 'controls' => array(
Index: trunk/extensions/Maps/Maps_Mapper.php
@@ -31,8 +31,7 @@
3232 'zoom' => array(
3333 'type' => 'integer',
3434 'criteria' => array(
35 - 'not_empty' => array(),
36 - 'in_range' => array(0, 15)
 35+ 'not_empty' => array()
3736 )
3837 ),
3938 'width' => array(
Index: trunk/extensions/Maps/GoogleMaps/Maps_GoogleMaps.php
@@ -55,6 +55,7 @@
5656 $allowedTypes = self::getTypeNames();
5757
5858 $egMapsServices[self::SERVICE_NAME]['parameters']['default'] = $egMapsGoogleMapsZoom;
 59+ $egMapsServices[self::SERVICE_NAME]['parameters']['zoom']['criteria']['in_range'] = array(0, 20);
5960
6061 $egMapsServices[self::SERVICE_NAME]['parameters'] = array(
6162 'controls' => array(
Index: trunk/extensions/Maps/YahooMaps/Maps_YahooMaps.php
@@ -54,6 +54,7 @@
5555 $allowedTypes = MapsYahooMaps::getTypeNames();
5656
5757 $egMapsServices[self::SERVICE_NAME]['parameters']['default'] = $egMapsYahooMapsZoom;
 58+ $egMapsServices[self::SERVICE_NAME]['parameters']['zoom']['criteria']['in_range'] = array(1, 13);
5859
5960 $egMapsServices[self::SERVICE_NAME]['parameters'] = array(
6061 'controls' => array(

Status & tagging log