r61243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61242‎ | r61243 | r61244 >
Date:07:14, 19 January 2010
Author:nad
Status:deferred
Tags:
Comment:
use == not ===, maybe an empty string sometimes
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -480,7 +480,7 @@
481481 $tmp = array();
482482 $cols = $cols ? $cols : array_keys( $th );
483483 foreach ( $cols as $col ) {
484 - if ( $groupby === false || !in_array( $col, $groupby ) ) {
 484+ if ( $groupby == false || !in_array( $col, $groupby ) ) {
485485 $html = isset( $th[$col] ) ? $th[$col] : "<th>$col</th>";
486486 $table .= "$html\n";
487487 $tmp[] = $col;

Status & tagging log