r61239 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61238‎ | r61239 | r61240 >
Date:04:21, 19 January 2010
Author:aaron
Status:ok
Tags:
Comment:
Added missing review actions
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -559,7 +559,9 @@
560560 $wgLogActions['review/approve-i'] = 'review-logentry-app'; // sighted (first time)
561561 $wgLogActions['review/approve2-i'] = 'review-logentry-app'; // quality (first time)
562562 $wgLogActions['review/approve-a'] = 'review-logentry-app'; // sighted (auto)
 563+$wgLogActions['review/approve2-a'] = 'review-logentry-app'; // quality (auto)
563564 $wgLogActions['review/approve-ia'] = 'review-logentry-app'; // sighted (initial & auto)
 565+$wgLogActions['review/approve2-ia'] = 'review-logentry-app'; // quality (initial & auto)
564566 $wgLogActions['review/unapprove'] = 'review-logentry-dis'; // was sighted
565567 $wgLogActions['review/unapprove2'] = 'review-logentry-dis'; // was quality
566568
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -1510,7 +1510,7 @@
15111511 if ( !is_array( $flags ) ) {
15121512 if ( $oldSv ) { // use the last stable version if $flags not given
15131513 if( $user->isAllowed( 'bot' ) ) {
1514 - $flags = $oldSv->getTags(); // no change for bots
 1514+ $flags = $oldSv->getTags(); // no change for bot edits
15151515 } else {
15161516 $flags = self::getAutoReviewTags( $oldSv->getQuality() /* available */ );
15171517 }
Index: trunk/extensions/FlaggedRevs/FlaggedRevsLogs.php
@@ -6,9 +6,7 @@
77 * $action is a valid review log action
88 */
99 public static function isReviewAction( $action ) {
10 - return in_array( $action,
11 - array( 'approve', 'approve2', 'approve-a', 'approve2-a', 'unapprove', 'unapprove2' )
12 - );
 10+ return preg_match( '/^(approve2?(-i|-a|-ia)?|unapprove2?)$/', $action );
1311 }
1412
1513 /**

Status & tagging log