r61105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61104‎ | r61105 | r61106 >
Date:22:38, 15 January 2010
Author:aaron
Status:ok
Tags:
Comment:
JS follow-up for r61104
Modified paths:
  • /trunk/extensions/FlaggedRevs/client/review.js (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/client/review.js
@@ -217,7 +217,6 @@
218218 if( response.indexOf('<suc#>') == 0 ) {
219219 document.title = wgAjaxReview.actioncomplete;
220220 if( rsubmit ) {
221 - rsubmit.disabled = ''; // unlock flag button
222221 // If flagging is just binary, flip the form
223222 if( usubmit ) {
224223 // Revision was flagged
@@ -229,9 +228,11 @@
230229 // Revision was unflagged
231230 } else if( usubmit.value == wgAjaxReview.sendingMsg ) {
232231 usubmit.value = wgAjaxReview.unflagMsg; // back to normal
 232+ rsubmit.disabled = ''; // unlock flag button
233233 }
234234 } else {
235235 rsubmit.value = wgAjaxReview.sendMsg; // back to normal
 236+ rsubmit.disabled = ''; // unlock flag button
236237 }
237238 }
238239 // Hide "review this" box on diffs
@@ -253,10 +254,10 @@
254255 } else {
255256 document.title = wgAjaxReview.actionfailed;
256257 if( rsubmit ) {
257 - rsubmit.disabled = ''; // unlock flag button
258258 // Revision was flagged
259259 if( rsubmit.value == wgAjaxReview.sendingMsg ) {
260260 rsubmit.value = wgAjaxReview.flagMsg; // back to normal
 261+ rsubmit.disabled = ''; // unlock flag button
261262 // Revision was unflagged
262263 } else if( usubmit.value == wgAjaxReview.sendingMsg ) {
263264 usubmit.value = wgAjaxReview.unflagMsg; // back to normal

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61104Disable 'review' button for already flagged revisions for binary flag case (e...aaron22:35, 15 January 2010

Status & tagging log