r61095 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61094‎ | r61095 | r61096 >
Date:18:48, 15 January 2010
Author:catrope
Status:ok
Tags:
Comment:
UsabilityInitiative: Fix quirky EditWarning bug where EW is triggered on Special:Import's success page
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Vector/Modules/EditWarning/EditWarning.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Modules/EditWarning/EditWarning.js
@@ -1,8 +1,8 @@
22 /* JavaScript for EditWarning extension */
33
44 mw.ready( function() {
5 - // Check if EditWarning is enabled
6 - if ( !wgVectorEnabledModules.editwarning ) {
 5+ // Check if EditWarning is enabled and if we need it
 6+ if ( !wgVectorEnabledModules.editwarning || $j( '#wpTextbox1' ).size() == 0 ) {
77 return true;
88 }
99 // Get the original values of some form elements
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -14,15 +14,15 @@
1515 'raw' => array(
1616 array( 'src' => 'Modules/CollapsibleNav/CollapsibleNav.js', 'version' => 6 ),
1717 array( 'src' => 'Modules/CollapsibleTabs/CollapsibleTabs.js', 'version' => 6 ),
18 - array( 'src' => 'Modules/EditWarning/EditWarning.js', 'version' => 4 ),
 18+ array( 'src' => 'Modules/EditWarning/EditWarning.js', 'version' => 5 ),
1919 array( 'src' => 'Modules/FooterCleanup/FooterCleanup.js', 'version' => 1 ),
2020 array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 5 ),
2121 ),
2222 'combined' => array(
23 - array( 'src' => 'Vector.combined.js', 'version' => 13 ),
 23+ array( 'src' => 'Vector.combined.js', 'version' => 14 ),
2424 ),
2525 'minified' => array(
26 - array( 'src' => 'Vector.combined.min.js', 'version' => 13 ),
 26+ array( 'src' => 'Vector.combined.min.js', 'version' => 14 ),
2727 ),
2828 );
2929 static $modules = array(

Status & tagging log