r60993 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60992‎ | r60993 | r60994 >
Date:23:05, 12 January 2010
Author:mah
Status:ok
Tags:
Comment:
follow-up r60986: Revert earlier test change - philip showed me the error of my ways.
Modified paths:
  • /trunk/phase3/tests/LanguageConverterTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/LanguageConverterTest.php
@@ -81,11 +81,12 @@
8282 $this->assertEquals('tg-latn', $this->lc->getPreferredVariant(true, true));
8383
8484 $wgRequest->setVal('variant', 'tg');
85 - $wgUser->setOption('variant', 'tg-latn');
 85+ $wgUser->setOption('variant', 'tg-latn'); // The user's data is ignored
 86+ // because the variant is set in the URL.
8687 $this->lc = new TestConverter( $this->lang, 'tg',
8788 array( 'tg', 'tg-latn' ) );
88 - $this->assertEquals('tg-latn', $this->lc->getPreferredVariant(true, false));
89 - $this->assertEquals('tg-latn', $this->lc->getPreferredVariant(true, true));
 89+ $this->assertEquals('tg', $this->lc->getPreferredVariant(true, false));
 90+ $this->assertEquals('tg', $this->lc->getPreferredVariant(true, true));
9091
9192 $wgRequest->setVal('variant', null);
9293 $wgDefaultLanguageVariant = 'tg-latn';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r609861. Add a new feature to LanguageConverter, for supporting nested using of man...philip20:54, 12 January 2010

Status & tagging log