r60920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60919‎ | r60920 | r60921 >
Date:04:23, 11 January 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fixed code style issues from r58887.
Modified paths:
  • /trunk/extensions/SecurePoll/includes/ballots/Ballot.php (modified) (history)
  • /trunk/extensions/SecurePoll/includes/ballots/RadioRangeBallot.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SecurePoll/includes/ballots/RadioRangeBallot.php
@@ -78,11 +78,11 @@
7979 return $labels;
8080 }
8181
82 - function getMessageNames( $entity=null ) {
83 - if( $entity===null || $entity->getType() !== 'question' ) {
 82+ function getMessageNames( $entity = null ) {
 83+ if ( $entity === null || $entity->getType() !== 'question' ) {
8484 return array();
8585 }
86 - if( !$entity->getProperty( 'column-label-msgs' ) ) {
 86+ if ( !$entity->getProperty( 'column-label-msgs' ) ) {
8787 return array();
8888 }
8989 $msgs = array();
Index: trunk/extensions/SecurePoll/includes/ballots/Ballot.php
@@ -28,7 +28,9 @@
2929 * @return Array
3030 * @see SecurePoll_Election::getMessageNames()
3131 */
32 - function getMessageNames(){ return array(); }
 32+ function getMessageNames() {
 33+ return array();
 34+ }
3335
3436 /**
3537 * Called when the form is submitted. This returns a Status object which,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58887Fix code flow so that messages added to questions by the ballot type (ie colu...happy-melon22:26, 10 November 2009

Status & tagging log