r60814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60813‎ | r60814 | r60815 >
Date:23:36, 7 January 2010
Author:tstarling
Status:ok
Tags:
Comment:
Reverted r58313, pointless, does not fix the bug.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -3602,7 +3602,6 @@
36033603 }
36043604
36053605 protected function loadOptions() {
3606 - global $wgCookiePrefix;
36073606 $this->load();
36083607 if ( $this->mOptionsLoaded || !$this->getId() )
36093608 return;
@@ -3631,11 +3630,6 @@
36323631 $this->mOptionOverrides[$row->up_property] = $row->up_value;
36333632 $this->mOptions[$row->up_property] = $row->up_value;
36343633 }
3635 -
3636 - //null skin if User::mId is loaded out of session data without persistant credentials
3637 - if ( !isset( $_SESSION['wsToken'] ) && !isset( $_COOKIE["{$wgCookiePrefix}Token"] ) )
3638 - $this->mOptions['skin'] = null;
3639 -
36403634 }
36413635
36423636 $this->mOptionsLoaded = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58313Switch to default skin if user session found without persistent creds. Bug 19048freakolowsky14:19, 29 October 2009

Status & tagging log