r60806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60805‎ | r60806 | r60807 >
Date:20:17, 7 January 2010
Author:yaron
Status:deferred
Tags:
Comment:
Fixed "wrong form" check for forms that only contain multiple-instance templates
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc
@@ -419,9 +419,13 @@
420420 // send the user a warning
421421 // (multiple-instance templates have a greater chance of
422422 // getting repeated from one form to the next)
423 - if (! $allow_multiple) {
 423+ // - on second thought, allow even the presence of multiple-
 424+ // instance templates to validate that this is the correct
 425+ // form: the problem is that some forms contain *only* mutliple-
 426+ // instance templates
 427+ //if (! $allow_multiple) {
424428 $source_page_matches_this_form = true;
425 - }
 429+ //}
426430 }
427431 }
428432 // if the input is from the form (meaning the user has hit one

Status & tagging log