r60731 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60730‎ | r60731 | r60732 >
Date:14:00, 6 January 2010
Author:freakolowsky
Status:ok
Tags:
Comment:
Fixed variable name typo from r60665. (problems while sending file in previous attempt r60730)
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -855,7 +855,7 @@
856856 function fieldExists( $table, $field, $fname = 'DatabaseOracle::fieldExists' ) {
857857 $table = trim( $table, '"' );
858858
859 - if (isset($this->mFileInfoCache[$table.'.'.$field])) {
 859+ if (isset($this->mFieldInfoCache[$table.'.'.$field])) {
860860 return true;
861861 } elseif ( !isset( $this->fieldInfo_stmt ) ) {
862862 $this->fieldInfo_stmt = oci_parse( $this->mConn, 'SELECT * FROM wiki_field_info_full WHERE table_name = upper(:tab) and column_name = UPPER(:col)' );
@@ -871,7 +871,7 @@
872872 }
873873 $res = new ORAResult( $this, $this->fieldInfo_stmt );
874874 if ($res->numRows() != 0) {
875 - $this->mFileInfoCache[$table.'.'.$field] = new ORAField( $res->fetchRow() );
 875+ $this->mFieldInfoCache[$table.'.'.$field] = new ORAField( $res->fetchRow() );
876876 return true;
877877 } else {
878878 return false;
@@ -881,8 +881,8 @@
882882 function fieldInfo( $table, $field ) {
883883 $table = trim( $table, '"' );
884884
885 - if (isset($this->mFileInfoCache[$table.'.'.$field])) {
886 - return $this->mFileInfoCache[$table.'.'.$field];
 885+ if (isset($this->mFieldInfoCache[$table.'.'.$field])) {
 886+ return $this->mFieldInfoCache[$table.'.'.$field];
887887 } elseif ( !isset( $this->fieldInfo_stmt ) ) {
888888 $this->fieldInfo_stmt = oci_parse( $this->mConn, 'SELECT * FROM wiki_field_info_full WHERE table_name = upper(:tab) and column_name = UPPER(:col)' );
889889 }
@@ -896,8 +896,8 @@
897897 return false;
898898 }
899899 $res = new ORAResult( $this, $this->fieldInfo_stmt );
900 - $this->mFileInfoCache[$table.'.'.$field] = new ORAField( $res->fetchRow() );
901 - return $this->mFileInfoCache[$table.'.'.$field];
 900+ $this->mFieldInfoCache[$table.'.'.$field] = new ORAField( $res->fetchRow() );
 901+ return $this->mFieldInfoCache[$table.'.'.$field];
902902 }
903903
904904 function begin( $fname = '' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r60912Use string interpolation, not ....simetrical23:24, 10 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60665fixme for r58356freakolowsky13:35, 5 January 2010
r60730Fixed variable name typo from r60665.freakolowsky13:52, 6 January 2010

Status & tagging log