r60661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60660‎ | r60661 | r60662 >
Date:12:13, 5 January 2010
Author:jojo
Status:ok
Tags:
Comment:
removed login-to-save text

Fixes http://code.pediapress.com/wiki/ticket/720
Modified paths:
  • /trunk/extensions/Collection/Collection.templates.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.templates.php
@@ -130,21 +130,17 @@
131131
132132 <?php
133133 if ($GLOBALS['wgUser']->isLoggedIn()) {
134 - $showLoginInfo = false;
135134 $canSaveUserPage = $GLOBALS['wgUser']->isAllowed('collectionsaveasuserpage');
136135 $canSaveCommunityPage = $GLOBALS['wgUser']->isAllowed('collectionsaveascommunitypage');
137 - } else {
138 - $showLoginInfo = true;
139136 }
140 - if ($GLOBALS['wgEnableWriteAPI'] && ($showLoginInfo || $canSaveUserPage || $canSaveCommunityPage)) {
 137+ if ($GLOBALS['wgEnableWriteAPI'] && ($canSaveUserPage || $canSaveCommunityPage)) {
141138 ?>
142139 <div id="coll-savebox" style="margin-bottom: 10px; padding: 10px; border: 1px solid #aaa; background-color: #f9f9f9;">
143140 <h2><span class="mw-headline"><?php $this->msg('coll-save_collection_title') ?></span></h2>
144141 <?php
145 - if (!$showLoginInfo) {
146 - $this->msgWiki('coll-save_collection_text');
147 - $bookname = wfMsgForContent('coll-collections');
148 - $communityCollNS = $GLOBALS['wgCommunityCollectionNamespace'];
 142+ $this->msgWiki('coll-save_collection_text');
 143+ $bookname = wfMsgForContent('coll-collections');
 144+ $communityCollNS = $GLOBALS['wgCommunityCollectionNamespace'];
149145 ?>
150146 <form id="saveForm" action="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrl('Book')) ?>" method="post">
151147 <table style="width:100%; background-color: transparent;"><tbody>
@@ -181,9 +177,7 @@
182178 <input name="bookcmd" type="hidden" value="save_collection" />
183179 </form>
184180
185 - <?php } else {
186 - $this->msgWiki('coll-login_to_save');
187 - }
 181+ <?php
188182 $this->msgWiki('coll-save_category');
189183 ?>
190184 </div>

Status & tagging log