r60583 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60582‎ | r60583 | r60584 >
Date:19:01, 3 January 2010
Author:ialex
Status:deferred
Tags:
Comment:
* Fix varibale name in global declaration
* Fix E_STRICT: Only variables should be passed by reference in extensions/QPoll/qp_user.php on line 77
Modified paths:
  • /trunk/extensions/QPoll/qp_user.php (modified) (history)

Diff [purge]

Index: trunk/extensions/QPoll/qp_user.php
@@ -74,7 +74,8 @@
7575 * Add this extension to the mediawiki's extensions list.
7676 */
7777 $qp_ExtDir = str_replace( "\\", "/", dirname(__FILE__) ); // filesys path with windows path fix
78 -$qp_top_dir = array_pop( explode( '/', $qp_ExtDir ) );
 78+$dirs = explode( '/', $qp_ExtDir );
 79+$qp_top_dir = array_pop( $dirs );
7980 $qp_ScriptPath = $wgScriptPath . '/extensions' . ( ( $qp_top_dir == 'extensions' ) ? '' : '/' . $qp_top_dir ); // apache virtual path
8081
8182 $wgExtensionMessagesFiles['QPoll'] = $qp_ExtDir . '/qp_i18n.php';
@@ -128,7 +129,7 @@
129130 global $qp_ScriptPath;
130131 global $wgParser;
131132 global $wgExtensionCredits;
132 - global $wgQPollFunctionHook;
 133+ global $wgQPollFunctionsHook;
133134 global $wgContLang;
134135 global $wgJsMimeType, $wgOut;
135136 global $qp_enable_showresults;

Status & tagging log