r60423 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60422‎ | r60423 | r60424 >
Date:06:59, 27 December 2009
Author:dale
Status:deferred
Tags:
Comment:
* increased aplimit to subtitle listing query ( support more than 10 languages per video )
* fixed volume layout for kSkin in small players
* bumped script version
Modified paths:
  • /branches/js2-work/phase3/js/mwEmbed/modules/TimedText/mw.TimedText.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/mwEmbed.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js (modified) (history)
  • /branches/js2-work/phase3/js/mwEmbed/skins/kskin/playerSkin.css (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js/mwEmbed/skins/kskin/playerSkin.css
@@ -125,7 +125,7 @@
126126 cursor: pointer;
127127 float: right;
128128 list-style: none outside none;
129 - margin: 1px;
 129+ margin-top: 2px;
130130 padding: 0px 0;
131131 width: 23px;
132132 height: 16px;
@@ -367,7 +367,7 @@
368368 }
369369
370370 .k-player .volume_control {
371 - margin-right: 0px;
 371+ margin-right: 2px;
372372 width: 16px;
373373 }
374374
Index: branches/js2-work/phase3/js/mwEmbed/modules/TimedText/mw.TimedText.js
@@ -321,7 +321,7 @@
322322 * Get the layout mode
323323 *
324324 * Takes into consideration:
325 - * Playback method overlays support ( have to put subtiles bellow video )
 325+ * Playback method overlays support ( have to put subtitles bellow video )
326326 *
327327 */
328328 getLayoutMode: function(){
@@ -1213,6 +1213,7 @@
12141214 'list' : 'allpages',
12151215 'apprefix' : titleKey,
12161216 'apnamespace' : this.getTimedTextNS(),
 1217+ 'aplimit' : 200,
12171218 'prop':'revisions'
12181219 };
12191220 mw.getJSON( this.api_url, request, function( sourcePages ) {
Index: branches/js2-work/phase3/js/mwEmbed/mwEmbed.js
@@ -1747,9 +1747,9 @@
17481748 var currentSheet = $j( this) .attr( 'href' );
17491749 var sheetParts = currentSheet.split('?');
17501750 var urlParts = url.split('?');
1751 - //if the base url's match check the pamaters:
 1751+ //if the base url's match check the parameters:
17521752 if( sheetParts[0] == urlParts[0] && sheetParts[1]){
1753 - mw.log(" sheet compare: " + sheetParts[1].split( '&' ).sort().join('') + ' != ' + urlParts[1].split('&').sort().join(''));
 1753+ //mw.log(" sheet compare: " + sheetParts[1].split( '&' ).sort().join('') + ' != ' + urlParts[1].split('&').sort().join(''));
17541754 //Check if url params match ( sort to do string compare )
17551755 if( sheetParts[1].split( '&' ).sort().join('') ==
17561756 urlParts[1].split('&').sort().join('') ){
@@ -1758,7 +1758,7 @@
17591759 }
17601760 } );
17611761 if( foundSheet ){
1762 - mw.log( 'sheet: ' + url + ' already included ' );
 1762+ mw.log( 'skiped sheet: ' + url);
17631763 return ;
17641764 }
17651765
@@ -1819,7 +1819,8 @@
18201820 if( ! mwpath ){
18211821 mw.log( "Error could not get mwEmbed path " );
18221822 return ;
1823 - }
 1823+ }
 1824+
18241825 // Update the cached var with the absolute path:
18251826 mwEmbedPath = mw.absoluteUrl( mwpath ) ;
18261827 return mwEmbedPath;
Index: branches/js2-work/phase3/js/mwEmbed/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r60371';
 8+var mwRemoteVersion = 'r72';
99 var mwUseScriptLoader = true;
1010
1111 // Setup up request Params:
@@ -104,6 +104,8 @@
105105 }
106106 }
107107 if ( vidIdList.length > 0 ) {
 108+ //reverse order the array so videos at the "top" get swaped first:
 109+ vidIdList = vidIdList.reverse();
108110 mwLoadPlayer(function(){
109111 //Load the "EmbedPlayer" module:
110112 // All the actual code was requested in our single script-loader call
@@ -234,7 +236,8 @@
235237 $j( '#' + vidId ).html( html_out )
236238 .css( 'height', pheight + 30 );
237239
238 - // Do the actual rewrite
 240+ // Do the actual rewrite
 241+ mw.log("rewrite: "+ vidId );
239242 $j( '#mwe_' + vidId ).embedPlayer();
240243 //issue an async request to rewrite the next clip
241244 if ( vidIdList.length != 0 ) {
@@ -245,7 +248,7 @@
246249
247250 }
248251 };
249 - // Process each item in the vidIdList (with setTimeout to avoid locking)
 252+ // Process current top item in vidIdList
250253 procVidId( vidIdList.pop() );
251254 }
252255

Status & tagging log