r60399 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60398‎ | r60399 | r60400 >
Date:20:10, 25 December 2009
Author:ialex
Status:deferred
Tags:
Comment:
* findSettings.php now ignores some MediaWiki settings
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)
  • /trunk/extensions/Configure/findSettings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/findSettings.php
@@ -131,8 +131,18 @@
132132 $m = array();
133133 preg_match_all( '/\[\[[Mm]anual:\$(wg[A-Za-z0-9]+)\|/', $cont, $m );
134134 $allSettings = array_unique( $m[1] );
 135+ $ignoreList = array(
 136+ 'wgEnableNewpagesUserFilter', 'wgOldChangeTagsIndex', 'wgVectorExtraStyles'
 137+ );
135138 } else {
136139 $allSettings = array_keys( $coreSettings->getAllSettings() );
 140+ $ignoreList = array(
 141+ 'wgAuth', 'wgCommandLineMode', 'wgCheckSerialized', 'wgConf','wgDBconnection',
 142+ 'wgEnableNewpagesUserFilter', 'wgEnableSerializedMessages', 'wgEnforceHtmlIds',
 143+ 'wgLegacySchemaConversion', 'wgMaintenanceScripts', 'wgMemCachedDebug',
 144+ 'wgOldChangeTagsIndex', 'wgProxyKey', 'wgValidSkinNames', 'wgVectorExtraStyles',
 145+ 'wgVersion'
 146+ );
137147 }
138148
139149 // Now we'll need to open DefaultSettings.php
@@ -150,7 +160,7 @@
151161 }
152162
153163 // let's show the results:
154 - printArray( 'missing', $missing );
 164+ printArray( 'missing', array_diff( $missing, $ignoreList ) );
155165 printArray( 'obsolete', $obsolete );
156166
157167 if ( count( $missing ) == 0 && count( $obsolete ) == 0 )
Index: trunk/extensions/Configure/CHANGELOG
@@ -1,6 +1,9 @@
22 This file lists changes on this extension.
33 Localisation updates are done on betawiki and aren't listed here.
44
 5+0.14.16 - 25 December 2009
 6+ findSettings.php now ignores some MediaWiki settings.
 7+
58 0.14.15 - 26 November 2009
69 Removed ScriptLoader usage (removed from MediaWiki).
710
Index: trunk/extensions/Configure/Configure.php
@@ -18,7 +18,7 @@
1919 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
2020 'description' => 'Allow authorised users to configure the wiki via a web-based interface',
2121 'descriptionmsg' => 'configure-desc',
22 - 'version' => '0.14.15',
 22+ 'version' => '0.14.16',
2323 );
2424
2525 # Configuration part

Status & tagging log