r60392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60391‎ | r60392 | r60393 >
Date:16:30, 25 December 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Semantic Maps 0.5.1 rc2.
Modified paths:
  • /trunk/extensions/SemanticMaps/FormInputs/SM_FormInputs.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayers.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenStreetMap/SM_OSM.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMaps.php
@@ -20,5 +20,5 @@
2121 die( 'Not an entry point.' );
2222 }
2323
24 -$egMapsServices['yahoomaps']['qp'] = array('class' => 'SMYahooMapsQP', 'file' => 'extensions/SemanticMaps/YahooMaps/SM_YahooMapsQP.php', 'local' => false);
25 -$egMapsServices['yahoomaps']['fi'] = array('class' => 'SMYahooMapsFormInput', 'file' => 'extensions/SemanticMaps/YahooMaps/SM_YahooMapsFormInput.php', 'local' => false);
\ No newline at end of file
 24+$egMapsServices['yahoomaps']['qp'] = array('class' => 'SMYahooMapsQP', 'file' => 'YahooMaps/SM_YahooMapsQP.php', 'local' => true);
 25+$egMapsServices['yahoomaps']['fi'] = array('class' => 'SMYahooMapsFormInput', 'file' => 'YahooMaps/SM_YahooMapsFormInput.php', 'local' => true);
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayers.php
@@ -20,5 +20,5 @@
2121 die( 'Not an entry point.' );
2222 }
2323
24 -$egMapsServices['openlayers']['qp'] = array('class' => 'SMOpenLayersQP', 'file' => 'extensions/SemanticMaps/OpenLayers/SM_OpenLayersQP.php', 'local' => false);
25 -$egMapsServices['openlayers']['fi'] = array('class' => 'SMOpenLayersFormInput', 'file' => 'extensions/SemanticMaps/OpenLayers/SM_OpenLayersFormInput.php', 'local' => false);
\ No newline at end of file
 24+$egMapsServices['openlayers']['qp'] = array('class' => 'SMOpenLayersQP', 'file' => 'OpenLayers/SM_OpenLayersQP.php', 'local' => true);
 25+$egMapsServices['openlayers']['fi'] = array('class' => 'SMOpenLayersFormInput', 'file' => 'OpenLayers/SM_OpenLayersFormInput.php', 'local' => true);
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/FormInputs/SM_FormInputs.php
@@ -43,11 +43,10 @@
4444
4545 // Loop through the service alliases, and add them as form input types.
4646 foreach ($serviceData['aliases'] as $alias) self::initFormHook($alias, $serviceData['fi'], $serviceName);
47 - }
 47+ }
4848
4949 // Add the 'map' form input type if there are mapping services that have FI's loaded.
5050 if ($hasFormInputs) self::initFormHook('map');
51 -
5251 }
5352 }
5453
@@ -73,7 +72,9 @@
7473 ),
7574 'service_name' => array(),
7675 'part_of_multiple' => array(),
77 - 'possible_values' => array(),
 76+ 'possible_values' => array(
 77+ 'type' => array('string', 'array'),
 78+ ),
7879 'is_list' => array(),
7980 'semantic_property' => array(),
8081 'value_labels' => array(),
@@ -92,7 +93,7 @@
9394
9495 if (isset($fi)) {
9596 if (! array_key_exists($fi['class'], $wgAutoloadClasses)) {
96 - $file = $fi['local'] ? $smgIP . '/' . $fi['file'] : $fi['file'];
 97+ $file = array_key_exists('local', $fi) && $fi['local'] ? $smgIP . '/' . $fi['file'] : $fi['file'];
9798 $wgAutoloadClasses[$fi['class']] = $file;
9899 }
99100 }
Index: trunk/extensions/SemanticMaps/OpenStreetMap/SM_OSM.php
@@ -20,5 +20,5 @@
2121 die( 'Not an entry point.' );
2222 }
2323
24 -$egMapsServices['osm']['qp'] = array('class' => 'SMOSMQP', 'file' => 'extensions/SemanticMaps/OpenStreetMap/SM_OSMQP.php', 'local' => false);
 24+$egMapsServices['osm']['qp'] = array('class' => 'SMOSMQP', 'file' => 'OpenStreetMap/SM_OSMQP.php', 'local' => true);
2525 //$egMapsServices['osm']['fi'] = array('class' => 'SMOSMFormInput', 'file' => 'extensions/SemanticMaps/OpenStreetMap/SM_OSMFormInput.php', 'local' => false);
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if (defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' )) {
39 - define('SM_VERSION', '0.5.1 rc1');
 39+ define('SM_VERSION', '0.5.1 rc2');
4040
4141 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
4242 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php
@@ -20,5 +20,5 @@
2121 die( 'Not an entry point.' );
2222 }
2323
24 -$egMapsServices['googlemaps']['qp'] = array('class' => 'SMGoogleMapsQP', 'file' => 'extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php', 'local' => false);
25 -$egMapsServices['googlemaps']['fi'] = array('class' => 'SMGoogleMapsFormInput', 'file' => 'extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php', 'local' => false);
\ No newline at end of file
 24+$egMapsServices['googlemaps']['qp'] = array('class' => 'SMGoogleMapsQP', 'file' => 'GoogleMaps/SM_GoogleMapsQP.php', 'local' => true);
 25+$egMapsServices['googlemaps']['fi'] = array('class' => 'SMGoogleMapsFormInput', 'file' => 'GoogleMaps/SM_GoogleMapsFormInput.php', 'local' => true);
\ No newline at end of file

Status & tagging log