r60334 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60333‎ | r60334 | r60335 >
Date:19:13, 23 December 2009
Author:yaron
Status:deferred
Tags:
Comment:
Different dimensions for window based on version of UploadWindow used
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormInputs.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormInputs.inc
@@ -43,7 +43,12 @@
4444 $query_string .= "&wpDestFile=$default_filename";
4545 $upload_window_url = $upload_window_page->getTitle()->getFullURL($query_string);
4646 $upload_label = wfMsg('upload');
47 - $text = " <a href=\"$upload_window_url\" title=\"$upload_label\" rel=\"iframe\" rev=\"width:550 height:380\">$upload_label</a>";
 47+ // window needs to be bigger for MediaWiki version 1.16+
 48+ if (class_exists('HTMLForm'))
 49+ $style = "width:650 height:500";
 50+ else
 51+ $style = '';
 52+ $text = " <a href=\"$upload_window_url\" title=\"$upload_label\" rel=\"iframe\" rev=\"$style\">$upload_label</a>";
4853 return $text;
4954 }
5055

Status & tagging log