r60266 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60265‎ | r60266 | r60267 >
Date:17:51, 21 December 2009
Author:aaron
Status:ok
Tags:
Comment:
Fixed r57659 for high concurrency situations
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1340,11 +1340,11 @@
13411341 } else {
13421342 wfDebug( __METHOD__ . ": ok. $key at $count $summary\n" );
13431343 }
1344 - $wgMemc->incr( $key );
13451344 } else {
13461345 wfDebug( __METHOD__ . ": adding record for $key $summary\n" );
1347 - $wgMemc->set( $key, 1, intval( $period ) ); // first ping
 1346+ $wgMemc->add( $key, 0, intval( $period ) ); // first ping
13481347 }
 1348+ $wgMemc->incr( $key );
13491349 }
13501350
13511351 wfProfileOut( __METHOD__ );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57659* (bug 20595) Don't increment ping value right after setting it the first tim...aaron23:54, 12 October 2009

Status & tagging log