r60263 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r60262‎ | r60263 | r60264 >
Date:16:13, 21 December 2009
Author:midom
Status:ok
Tags:
Comment:
Reverting r59993, per Tim's comment at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59993#c4885
Still, we need to rethink user 'invalidations' (probably by replacing user object, rather than just touching the user). There are way too many invalidation cases out there, that happen in parallel blocking out each other.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
——@@ -2282,6 +2282,7 @@
22832283 function addWatch( $title ) {
22842284 $wl = WatchedItem::fromUserTitle( $this, $title );
22852285 $wl->addWatch();
 2286+ $this->invalidateCache();
22862287 }
22872288
22882289 /**
——@@ -2291,6 +2292,7 @@
22922293 function removeWatch( $title ) {
22932294 $wl = WatchedItem::fromUserTitle( $this, $title );
22942295 $wl->removeWatch();
 2296+ $this->invalidateCache();
22952297 }
22962298
22972299 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59993I fail to see why we need to invalidate cache on watchlist edits here, do we ...midom14:52, 12 December 2009

Status & tagging log